Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata-idp.ts #139

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Update metadata-idp.ts #139

merged 1 commit into from
Oct 17, 2017

Conversation

wwindcloud
Copy link
Contributor

Fix typo for keysection use="encrypt" should be use="encryption", at least metadata generated from IDP should use valid value.

@wwindcloud
Update metadata-idp.ts
6a62894 
Fix typo for keysection use="encrypt" should be use="encryption", at least metadata generated from IDP should use valid value.
@coveralls
Copy link

coveralls commented Oct 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.74% when pulling 6a62894 on wwindcloud:wwindcloud-typo-fix-1 into b94e9ce on tngan:master.

@tngan tngan merged commit 328a925 into tngan:master Oct 17, 2017
@tngan
Copy link
Owner

tngan commented Oct 17, 2017

@wwindcloud Thanks for catching this, there is another typo in sp metadata construction as well.

@tngan
Copy link
Owner

tngan commented Oct 17, 2017

@wwindcloud updated 455e8ac

tngan added a commit that referenced this pull request Oct 17, 2017
@tngan
#139 Fix and enhancement on key descriptor usage
e628f52
@wwindcloud wwindcloud deleted the wwindcloud-typo-fix-1 branch October 31, 2017 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wwindcloud @coveralls @tngan