Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unique notification channel for the specific types #34

Closed
tamas646 opened this issue Jun 22, 2022 · 3 comments · Fixed by #187
Closed

Make unique notification channel for the specific types #34

tamas646 opened this issue Jun 22, 2022 · 3 comments · Fixed by #187
Labels
enhancement New feature or request

Comments

@tamas646
Copy link

Currently the app uses one notification channel (named 'notification_channel') for every notification (scheduled backup successful, scheduled backup unsuccessful...etc).

It would be great to have the notifications seperated to unique channels to be able to enable/disable them seperately. (for example to be able to disable only the 'scheduled update successful' notifications 😉)

@tmo1
Copy link
Owner

tmo1 commented Jun 23, 2022

Thank you for the suggestion - I'll consider implementing it. Given that at least currently, at most one scheduled backup takes place per day, is it really that useful to be able to disable that single daily success notification?

@tamas646
Copy link
Author

(For me currently not, because the daily backups are not working due to an issue: nextcloud/android#7846. :D)

I don't say it's urgent and must have feature, but yes, I think it would be useful. If you have e.g. three apps that create daily backups, you will receive three notifications per day just to inform you that everything is fine. And this could be annoying at some point.
But the choice is yours, it's just a suggestion.

@tmo1
Copy link
Owner

tmo1 commented Jun 24, 2022

(For me currently not, because the daily backups are not working due to an issue: nextcloud/android#7846 (comment). :D)

Hm, I'm not sure I understand this, since we don't do any file renaming.

I don't say it's urgent and must have feature, but yes, I think it would be useful. If you have e.g. three apps that create daily backups, you will receive three notifications per day just to inform you that everything is fine. And this could be annoying at some point.

But the choice is yours, it's just a suggestion.

Got it. The changes to the code should be pretty simple, so I may just go ahead and do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants