Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace external call to fzf with skim #18

Closed
colemickens opened this issue Mar 27, 2023 · 3 comments
Closed

replace external call to fzf with skim #18

colemickens opened this issue Mar 27, 2023 · 3 comments

Comments

@colemickens
Copy link

Hi.

Prs.exe on windows currently fails in some scenarios since I don't have FZF installed. I think it would be great if FZF were replaced with Skim, a Rust equivalent:

https://github.com/lotabout/skim

Thank you!

@timvisee
Copy link
Owner

prs uses skim, but it is not supported on Windows. Therefore it chooses to use fzf on Windows as alternative.

This issue describes that skim is still not available on Windows: skim-rs/skim#293

@colemickens
Copy link
Author

Oh no... thanks for the fast courteous response, sorry I hadn't found that first! (Not sure if you want to keep this open or not, I'll let you decide).

Thanks!

@timvisee
Copy link
Owner

Since I don't think Windows support will ever be added to skim I'll close this now.

Feel free to open this again if you have another suggestion to improve on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants