Angular 9 (Ivy) issue

[jongbonga]

ERROR in node_modules/angular-cc-library/lib/directives.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of CCPageModule, but could not be resolved to an NgModule class

Angular CLI: 9.0.1
Node: 10.16.0
OS: darwin x64

Angular: 9.0.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.25
@angular-devkit/build-angular     0.900.1
@angular-devkit/build-optimizer   0.900.1
@angular-devkit/build-webpack     0.900.1
@angular-devkit/core              9.0.1
@angular-devkit/schematics        9.0.1
@angular/cli                      9.0.1
@ngtools/webpack                  9.0.1
@schematics/angular               8.1.3
@schematics/update                0.900.1
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

[aserralta]

I have the same issue as @jongbonga

[antoine-souesme]

Same issue here.

[DanWebb]

I think I'm seeing the same issue but with a different error message:

Importing CreditCardDirectivesModule which does not have a ɵmod property

Unexpected value 'CreditCardDirectivesModule' imported by the module 'ControlCardNumberModule'. Please add an @NgModule annotation.

I was able to fix it by manually re-creating this module...:

import { NgModule } from '@angular/core';
import { CreditCardFormatDirective, ExpiryFormatDirective, CvcFormatDirective } from 'angular-cc-library';

const CREDIT_CARD_LIBRARY_DIRECTIVES = [
  CreditCardFormatDirective,
  ExpiryFormatDirective,
  CvcFormatDirective
];

@NgModule({
  declarations: [CREDIT_CARD_LIBRARY_DIRECTIVES],
  exports: [CREDIT_CARD_LIBRARY_DIRECTIVES]
})
export class CreditCardDirectivesModule {}

// Then...

@NgModule({
  imports: [CreditCardDirectivesModule, /* Other imports... */],
  // etc...
})
export class MyCustomModule { }

I guess it's some issue with the way the libraries built...?

[jongbonga]

@DanWebb are you able to run it with ivy enabled after your fix?

I guess @nogorilla is not maintaining the library anymore... some issues from 2018 are still unanswered.

We are on our own people ✊🏼☹️

[DanWebb]

Sorry @jongbonga spoke too soon the above fails on a prod build in v9, it fooled me because it passed tests.

I'm sure it'll be something to do with how the libraries built or exported though.

[jongbonga]

I don’t want to get rid of this library since all the others are not satisfying my needs! But also, Can’t rock A9 without Ivy... it doesn’t make sense to me.

Any other cc validation as good as this one? that compile with Ivy? Thanks for sharing 🙂

[DanWebb]

I've put some time into investigating and I think the issue is to do with the .metadata.json file not being in the root directory of the package https://unpkg.com/browse/angular-cc-library@1.2.5/

Anyway, there are lots of other similar occurrences coming up since the v9 release...

• Appears in the NgModule.imports of <MyLibrary>, but could not be resolved to an NgModule class angular/angular#34983
• IVY Error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class angular/angular#35399
• PortalModule Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class angular/angular#35411
  ...etc

I'm out of time and none of the listed solutions have worked so if nobody else has an idea I suppose it'll have to be left for a bit until enough people bring it up for an official solution to be released or an alternative lib is written...

[antoine-souesme]

Yes, for now we can just upgrade angular to 9.x and disable Ivy...

[rkajbaf]

It would be great to be able to use this with Ivy... for now I've removed this library but will gladly add it back into my project once this is fixed.

FWIW I think all that has to happen is that the package needs to be redeployed in a non minified fashion.

[antoine-souesme]

Unfortunately this library does not seem to be maintained anymore..

[thehashrocket]

would it make sense to fork it and do the necessary updates?

[EfraimLA]

So we should leave this library for Ivy?

[timofei-iatsenko]

will be fixed when this PR gets merged #64

[EfraimLA]

Cool, so close issue?

[born2net]

same issue... fixed?
TX!

[timofei-iatsenko]

The PR is merged, and will be included in upcoming release with some other features

[born2net]

tx!

[jongbonga]

Thanks @thekip

[timofei-iatsenko]

Fixed in 2.0.0 https://github.com/nogorilla/angular-cc-library/releases/tag/v2.0.0