You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation for SpiClient::select/SpiClient::update says that select should be used for operations that only read, and update should be used for operations that write. Currently all of our tests use select for all queries, even those that write to the database. The queries that write should be changed to use update.
This isn't much of a problem currently since select and update have the same implementations, but in future versions of pgx using select to modify the database might not work.
The text was updated successfully, but these errors were encountered:
We fixed this in d498dc6 by replacing all uses of SpiClient::select with SpiClient::update. (Ideally we would still use select for read-only queries, but right now we only use SPI in tests so it's not very important.)
The documentation for
SpiClient::select
/SpiClient::update
says thatselect
should be used for operations that only read, andupdate
should be used for operations that write. Currently all of our tests useselect
for all queries, even those that write to the database. The queries that write should be changed to useupdate
.This isn't much of a problem currently since
select
andupdate
have the same implementations, but in future versions of pgx usingselect
to modify the database might not work.The text was updated successfully, but these errors were encountered: