Remove use of doc_cfg feature

jhpratt · jhpratt · commit 44382c30f413 · 2022-10-03T03:52:14.000-04:00
`doc_auto_cfg` is smart enough to correctly tag all cases now
diff --git a/src/error/format.rs b/src/error/format.rs
@@ -8,7 +8,6 @@ use crate::error;
 /// An error occurred when formatting.
 #[non_exhaustive]
 #[allow(missing_copy_implementations)]
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]
 #[derive(Debug)]
 pub enum Format {
     /// The type being formatted does not contain sufficient information to format a component.
@@ -65,14 +64,12 @@ impl std::error::Error for Format {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]
 impl From<Format> for crate::Error {
     fn from(original: Format) -> Self {
         Self::Format(original)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]
 impl TryFrom<crate::Error> for Format {
     type Error = error::DifferentVariant;
 
diff --git a/src/error/indeterminate_offset.rs b/src/error/indeterminate_offset.rs
@@ -5,7 +5,6 @@ use core::fmt;
 use crate::error;
 
 /// The system's UTC offset could not be determined at the given datetime.
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "local-offset")))]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub struct IndeterminateOffset;
 
@@ -18,14 +17,12 @@ impl fmt::Display for IndeterminateOffset {
 #[cfg(feature = "std")]
 impl std::error::Error for IndeterminateOffset {}
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "local-offset")))]
 impl From<IndeterminateOffset> for crate::Error {
     fn from(err: IndeterminateOffset) -> Self {
         Self::IndeterminateOffset(err)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "std")))]
 impl TryFrom<crate::Error> for IndeterminateOffset {
     type Error = error::DifferentVariant;
 
diff --git a/src/error/invalid_format_description.rs b/src/error/invalid_format_description.rs
@@ -6,10 +6,6 @@ use core::fmt;
 use crate::error;
 
 /// The format description provided was not valid.
-#[cfg_attr(
-    __time_03_docs,
-    doc(cfg(all(any(feature = "formatting", feature = "parsing"), feature = "alloc")))
-)]
 #[non_exhaustive]
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub enum InvalidFormatDescription {
@@ -43,20 +39,12 @@ pub enum InvalidFormatDescription {
     },
 }
 
-#[cfg_attr(
-    __time_03_docs,
-    doc(cfg(all(any(feature = "formatting", feature = "parsing"), feature = "alloc")))
-)]
 impl From<InvalidFormatDescription> for crate::Error {
     fn from(original: InvalidFormatDescription) -> Self {
         Self::InvalidFormatDescription(original)
     }
 }
 
-#[cfg_attr(
-    __time_03_docs,
-    doc(cfg(all(any(feature = "formatting", feature = "parsing"), feature = "alloc")))
-)]
 impl TryFrom<crate::Error> for InvalidFormatDescription {
     type Error = error::DifferentVariant;
 
diff --git a/src/error/parse.rs b/src/error/parse.rs
@@ -5,7 +5,6 @@ use core::fmt;
 use crate::error::{self, ParseFromDescription, TryFromParsed};
 
 /// An error that occurred at some stage of parsing.
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 #[allow(variant_size_differences)]
 #[non_exhaustive]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
@@ -40,14 +39,12 @@ impl std::error::Error for Parse {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl From<TryFromParsed> for Parse {
     fn from(err: TryFromParsed) -> Self {
         Self::TryFromParsed(err)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl TryFrom<Parse> for TryFromParsed {
     type Error = error::DifferentVariant;
 
@@ -59,14 +56,12 @@ impl TryFrom<Parse> for TryFromParsed {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl From<ParseFromDescription> for Parse {
     fn from(err: ParseFromDescription) -> Self {
         Self::ParseFromDescription(err)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl TryFrom<Parse> for ParseFromDescription {
     type Error = error::DifferentVariant;
 
@@ -78,7 +73,6 @@ impl TryFrom<Parse> for ParseFromDescription {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl From<Parse> for crate::Error {
     fn from(err: Parse) -> Self {
         match err {
@@ -89,7 +83,6 @@ impl From<Parse> for crate::Error {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl TryFrom<crate::Error> for Parse {
     type Error = error::DifferentVariant;
 
diff --git a/src/error/parse_from_description.rs b/src/error/parse_from_description.rs
@@ -5,7 +5,6 @@ use core::fmt;
 use crate::error;
 
 /// An error that occurred while parsing the input into a [`Parsed`](crate::parsing::Parsed) struct.
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 #[non_exhaustive]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum ParseFromDescription {
@@ -30,14 +29,12 @@ impl fmt::Display for ParseFromDescription {
 #[cfg(feature = "std")]
 impl std::error::Error for ParseFromDescription {}
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl From<ParseFromDescription> for crate::Error {
     fn from(original: ParseFromDescription) -> Self {
         Self::ParseFromDescription(original)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl TryFrom<crate::Error> for ParseFromDescription {
     type Error = error::DifferentVariant;
 
diff --git a/src/error/try_from_parsed.rs b/src/error/try_from_parsed.rs
@@ -6,7 +6,6 @@ use crate::error;
 
 /// An error that occurred when converting a [`Parsed`](crate::parsing::Parsed) to another type.
 #[non_exhaustive]
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum TryFromParsed {
     /// The [`Parsed`](crate::parsing::Parsed) did not include enough information to construct the
@@ -54,14 +53,12 @@ impl std::error::Error for TryFromParsed {
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl From<TryFromParsed> for crate::Error {
     fn from(original: TryFromParsed) -> Self {
         Self::TryFromParsed(original)
     }
 }
 
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
 impl TryFrom<crate::Error> for TryFromParsed {
     type Error = error::DifferentVariant;
 
diff --git a/src/format_description/parse.rs b/src/format_description/parse.rs
@@ -80,7 +80,6 @@ fn parse_item<'a>(
 ///
 /// The syntax for the format description can be found in [the
 /// book](https://time-rs.github.io/book/api/format-description.html).
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "alloc")))]
 pub fn parse(s: &str) -> Result<Vec<FormatItem<'_>>, InvalidFormatDescription> {
     let mut compound = Vec::new();
     let mut loc = 0;
diff --git a/src/formatting/formattable.rs b/src/formatting/formattable.rs
@@ -27,7 +27,6 @@ mod sealed {
     use super::*;
 
     /// Format the item using a format description, the intended output, and the various components.
-    #[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]
     pub trait Sealed {
         /// Format the item into the provided output, returning the number of bytes written.
         fn format_into(
diff --git a/src/instant.rs b/src/instant.rs
@@ -25,7 +25,6 @@ use crate::Duration;
 ///
 /// This implementation allows for operations with signed [`Duration`]s, but is otherwise identical
 /// to [`std::time::Instant`].
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "std")))]
 #[repr(transparent)]
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct Instant(pub StdInstant);
diff --git a/src/lib.rs b/src/lib.rs
@@ -81,7 +81,7 @@
 //! requires the local offset will return the `Err` variant when otherwise unsound.
 
 #![doc(html_playground_url = "https://play.rust-lang.org")]
-#![cfg_attr(__time_03_docs, feature(doc_cfg, doc_auto_cfg, doc_notable_trait))]
+#![cfg_attr(__time_03_docs, feature(doc_auto_cfg, doc_notable_trait))]
 #![cfg_attr(
     __time_03_docs,
     deny(rustdoc::broken_intra_doc_links, rustdoc::private_intra_doc_links)
@@ -315,13 +315,10 @@ mod offset_date_time;
 pub mod parsing;
 mod primitive_date_time;
 #[cfg(feature = "quickcheck")]
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "quickcheck")))]
 mod quickcheck;
 #[cfg(feature = "rand")]
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "rand")))]
 mod rand;
 #[cfg(feature = "serde")]
-#[cfg_attr(__time_03_docs, doc(cfg(feature = "serde")))]
 #[allow(missing_copy_implementations, missing_debug_implementations)]
 pub mod serde;
 mod sys;
diff --git a/src/offset_date_time.rs b/src/offset_date_time.rs
@@ -55,7 +55,6 @@ impl OffsetDateTime {
     /// assert_eq!(OffsetDateTime::now_utc().offset(), offset!(UTC));
     /// ```
     #[cfg(feature = "std")]
-    #[cfg_attr(__time_03_docs, doc(cfg(feature = "std")))]
     pub fn now_utc() -> Self {
         #[cfg(all(
             target_arch = "wasm32",
@@ -84,7 +83,6 @@ impl OffsetDateTime {
     /// # }
     /// ```
     #[cfg(feature = "local-offset")]
-    #[cfg_attr(__time_03_docs, doc(cfg(feature = "local-offset")))]
     pub fn now_local() -> Result<Self, error::IndeterminateOffset> {
         let t = Self::now_utc();
         Ok(t.to_offset(UtcOffset::local_offset_at(t)?))
diff --git a/src/parsing/parsable.rs b/src/parsing/parsable.rs
@@ -27,7 +27,6 @@ mod sealed {
     use super::*;
 
     /// Parse the item using a format description and an input.
-    #[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]
     pub trait Sealed {
         /// Parse the item into the provided [`Parsed`] struct.
         ///

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ use crate::error;`
`8`	`8`	`/// An error occurred when formatting.`
`9`	`9`	`#[non_exhaustive]`
`10`	`10`	`#[allow(missing_copy_implementations)]`
`11`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]`
`12`	`11`	`#[derive(Debug)]`
`13`	`12`	`pub enum Format {`
`14`	`13`	`/// The type being formatted does not contain sufficient information to format a component.`
`@@ -65,14 +64,12 @@ impl std::error::Error for Format {`
`65`	`64`	`}`
`66`	`65`	`}`
`67`	`66`
`68`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]`
`69`	`67`	`impl From<Format> for crate::Error {`
`70`	`68`	`fn from(original: Format) -> Self {`
`71`	`69`	`Self::Format(original)`
`72`	`70`	`}`
`73`	`71`	`}`
`74`	`72`
`75`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "formatting")))]`
`76`	`73`	`impl TryFrom<crate::Error> for Format {`
`77`	`74`	`type Error = error::DifferentVariant;`
`78`	`75`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ use core::fmt;`
`5`	`5`	`use crate::error::{self, ParseFromDescription, TryFromParsed};`
`6`	`6`
`7`	`7`	`/// An error that occurred at some stage of parsing.`
`8`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`9`	`8`	`#[allow(variant_size_differences)]`
`10`	`9`	`#[non_exhaustive]`
`11`	`10`	`#[derive(Debug, Clone, Copy, PartialEq, Eq)]`
`@@ -40,14 +39,12 @@ impl std::error::Error for Parse {`
`40`	`39`	`}`
`41`	`40`	`}`
`42`	`41`
`43`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`44`	`42`	`impl From<TryFromParsed> for Parse {`
`45`	`43`	`fn from(err: TryFromParsed) -> Self {`
`46`	`44`	`Self::TryFromParsed(err)`
`47`	`45`	`}`
`48`	`46`	`}`
`49`	`47`
`50`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`51`	`48`	`impl TryFrom<Parse> for TryFromParsed {`
`52`	`49`	`type Error = error::DifferentVariant;`
`53`	`50`
`@@ -59,14 +56,12 @@ impl TryFrom<Parse> for TryFromParsed {`
`59`	`56`	`}`
`60`	`57`	`}`
`61`	`58`
`62`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`63`	`59`	`impl From<ParseFromDescription> for Parse {`
`64`	`60`	`fn from(err: ParseFromDescription) -> Self {`
`65`	`61`	`Self::ParseFromDescription(err)`
`66`	`62`	`}`
`67`	`63`	`}`
`68`	`64`
`69`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`70`	`65`	`impl TryFrom<Parse> for ParseFromDescription {`
`71`	`66`	`type Error = error::DifferentVariant;`
`72`	`67`
`@@ -78,7 +73,6 @@ impl TryFrom<Parse> for ParseFromDescription {`
`78`	`73`	`}`
`79`	`74`	`}`
`80`	`75`
`81`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`82`	`76`	`impl From<Parse> for crate::Error {`
`83`	`77`	`fn from(err: Parse) -> Self {`
`84`	`78`	`match err {`
`@@ -89,7 +83,6 @@ impl From<Parse> for crate::Error {`
`89`	`83`	`}`
`90`	`84`	`}`
`91`	`85`
`92`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`93`	`86`	`impl TryFrom<crate::Error> for Parse {`
`94`	`87`	`type Error = error::DifferentVariant;`
`95`	`88`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ use crate::error;`
`6`	`6`
`7`	`7`	/// An error that occurred when converting a [`Parsed`](crate::parsing::Parsed) to another type.
`8`	`8`	`#[non_exhaustive]`
`9`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`10`	`9`	`#[derive(Debug, Clone, Copy, PartialEq, Eq)]`
`11`	`10`	`pub enum TryFromParsed {`
`12`	`11`	/// The [`Parsed`](crate::parsing::Parsed) did not include enough information to construct the
`@@ -54,14 +53,12 @@ impl std::error::Error for TryFromParsed {`
`54`	`53`	`}`
`55`	`54`	`}`
`56`	`55`
`57`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`58`	`56`	`impl From<TryFromParsed> for crate::Error {`
`59`	`57`	`fn from(original: TryFromParsed) -> Self {`
`60`	`58`	`Self::TryFromParsed(original)`
`61`	`59`	`}`
`62`	`60`	`}`
`63`	`61`
`64`		`-#[cfg_attr(__time_03_docs, doc(cfg(feature = "parsing")))]`
`65`	`62`	`impl TryFrom<crate::Error> for TryFromParsed {`
`66`	`63`	`type Error = error::DifferentVariant;`
`67`	`64`