error_code: re-format metafile #8870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5kbpers
added
the
needs-cherry-pick-release-4.0
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
5kbpers
force-pushed
the
error-code-gen
branch
from
81033aa to
dd59c4e
Compare
lonng
reviewed
Oct 22, 2020
lonng
approved these changes
Oct 22, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
5kbpers
force-pushed
the
error-code-gen
branch
from
4e3cbc6 to
3ecb234
Compare
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
sticnarf
reviewed
Oct 22, 2020
| ["KV:Codec:Io"] | ||
| error = ''' | ||
| KV:Codec:Io | ||
| ''' |
There was a problem hiding this comment.
It is intended that there is a trailing newline?
There was a problem hiding this comment.
It's OK, we can trim space when the tiup errdoc component loads them.
ti-srebot
approved these changes
Oct 22, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
Wow |
It's code freeze day! |
|
/run-all-tests |
|
@5kbpers merge failed. |
Seems like a CI environment issue. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@5kbpers merge failed. |
|
/merge |
|
/run-all-tests |
|
@5kbpers merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tikv
that referenced
this pull request
Oct 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #8877 |
5kbpers
pushed a commit
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers tangminghua@pingcap.com
What is changed and how it works?
Proposal: xxx
What's Changed:
Re-format metafile of error codes.
Related changes
Check List
Tests
Release note