run asan in CI and stabilize write barrier test #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crossbeam channel will definitely cause race condition, as a feature. So this won’t work. |
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
FYI tikv/agatedb#51 |
Thanks for the pointer, but crossbeam is actually not needed anymore after #77. Anyhow, sanitizer currently can't build, seemingly caused by https://github.com/HdrHistogram/HdrHistogram_rust. I might look into that later. |
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
|
BTW, running ASAN also requires |
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie xy.tao@outlook.com
Run ASAN in linux CI pipeline. The write barrier test is unstable when ran under asan/miri, fixing it. Also some housekeeping work: remove build step in CI, remove useless code.
TSAN still can't run because we use crossbeam channel for parallel recovery.