Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review TPCH runs #284

Closed
krlmlr opened this issue Oct 19, 2024 · 2 comments
Closed

Review TPCH runs #284

krlmlr opened this issue Oct 19, 2024 · 2 comments
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 19, 2024

Query 10 didn't finish on my machine for sf=1. I suspect this is due to our use of the "full compatibility" operators from the rfuns extension for comparison. We might want to use faster variants in "good" cases (e.g., compare a column with a constant) so that duckdb can optimize.

Related: #270, CC @toppyy.

@krlmlr
Copy link
Member Author

krlmlr commented Nov 3, 2024

All good now, this was due to undesired materialization, #289.

@krlmlr
Copy link
Member Author

krlmlr commented Dec 14, 2024

The TPCH data changed in duckdb 0.8.0, in particular, the o_comment column in the orders table. @Tmonster @hannes: does that ring a bell?

0.7.1

$ echo 'INSTALL tpch; LOAD tpch; CALL dbgen(sf = 0.01); SELECT * FROM orders LIMIT 1; ' | ./duckdb-0.7.1 -json
[{"o_orderkey":1,"o_custkey":370,"o_orderstatus":"O","o_totalprice":172799.48999999998449,"o_orderdate":"1996-01-02","o_orderpriority":"5-LOW","o_clerk":"Clerk#000000951","o_shippriority":0,"o_comment":"nstructions sleep furiously among "}]

1.1.3

$ echo 'INSTALL tpch; LOAD tpch; CALL dbgen(sf = 0.01); SELECT * FROM orders LIMIT 1; ' | duckdb -json
[{"o_orderkey":1,"o_custkey":370,"o_orderstatus":"O","o_totalprice":172799.49,"o_orderdate":"1996-01-02","o_orderpriority":"5-LOW","o_clerk":"Clerk#000000951","o_shippriority":0,"o_comment":"ly express platelets. deposits acc"}]

@krlmlr krlmlr closed this as completed Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant