Pre-release tidying

mikemahoney218 · mikemahoney218 · commit 6e844ff66eb7 · 2023-01-03T19:25:32.000-05:00
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -14,3 +14,4 @@
 ^data-raw$
 ^vignettes/articles$
 ^CRAN-SUBMISSION$
+^revdep$
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -56,7 +56,7 @@ Config/testthat/parallel: true
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.2.2
+RoxygenNote: 7.2.3
 LinkingTo: 
     cpp11
 SystemRequirements: C++11
diff --git a/NEWS.md b/NEWS.md
@@ -1,26 +1,32 @@
 # spatialsample (development version)
 
-* Outputs from `spatial_buffer_vfold_cv()` should now have the correct `radius` and `buffer` attributes (#110).
+## Breaking changes
+
+* `spatial_clustering_cv()` no longer accepts non-sf objects. Use 
+  `rsample::clustering_cv()` for these instead (#126).
+  
+* `spatial_clustering_cv()` now uses edge-to-edge distances, like the rest of
+  the package, rather than centroids (#126).
+
+## New features
 
 * All functions now have a `repeats` argument, defaulting to 1, allowing for 
-  repeated cross-validation. 
+  repeated cross-validation (#122, #125, #126). 
+
+* `spatial_clustering_cv()` now has a `distance_function` argument, set by 
+  default to `as.dist(sf::st_distance(x))` (#126).
+
+## Minor improvements and fixes
+
+* Outputs from `spatial_buffer_vfold_cv()` should now have the correct `radius` and `buffer` attributes (#110).
 
 * `spatial_buffer_vfold_cv()` now has the correct `id` values when using repeats (#116).
 
 * `spatial_buffer_vfold_cv()` now throws an error when `repeats > 1 && v >= nrow(data)` (#116).
 
 * The minimum `sf` version required is now `>= 1.0-9`, so that unit objects can be passed to `cellsize` in `spatial_block_cv()` (#113; #124).
 
-* `autoplot()` now handles repeated cross-validation properly.
-
-* `spatial_clustering_cv()` no longer accepts non-sf objects. Use 
-  `rsample::clustering_cv()` for these instead.
-  
-* `spatial_clustering_cv()` now uses edge-to-edge distances, like the rest of
-  the package, rather than centroids.
-  
-* `spatial_clustering_cv()` now has a `distance_function` argument, set by 
-  default to `as.dist(sf::st_distance(x))`. 
+* `autoplot()` now handles repeated cross-validation properly (#123).
 
 # spatialsample 0.2.1
 
diff --git a/R/data.R b/R/data.R
@@ -43,7 +43,7 @@
 #'   \item{geometry}{Geometry of each hexagon, encoded using EPSG:2249 as a coordinate reference system (NAD83 / Massachusetts Mainland (ftUS)). Note that the linear units of this CRS are in US feet.}
 #' }
 #'
-#' @source Canopy data is from \url{https://data.boston.gov/dataset/hex-tree-canopy-change-metrics2}.
-#' Heat data is from \url{https://data.boston.gov/dataset/hex-mean-heat-index2}.
+#' @source Canopy data is from \url{https://data.boston.gov/dataset/hex-tree-canopy-change-metrics}.
+#' Heat data is from \url{https://data.boston.gov/dataset/hex-mean-heat-index}.
 #' Most field definitions are from \url{https://data.boston.gov/dataset/canopy-change-assessment-data-dictionary}.
 "boston_canopy"
diff --git a/README.md b/README.md
@@ -20,13 +20,13 @@ The goal of spatialsample is to provide functions and classes for
 spatial resampling to use with
 [rsample](https://rsample.tidymodels.org/), including:
 
--   [spatial clustering
-    cross-validation](https://doi.org/10.1109/IGARSS.2012.6352393)
--   [spatial block cross-validation](https://doi.org/10.1111/ecog.02881)
--   [spatially buffered
-    cross-validation](https://doi.org/10.1111/geb.12161)
--   [leave-location-out
-    cross-validation](https://doi.org/10.1016/j.envsoft.2017.12.001)
+- [spatial clustering
+  cross-validation](https://doi.org/10.1109/IGARSS.2012.6352393)
+- [spatial block cross-validation](https://doi.org/10.1111/ecog.02881)
+- [spatially buffered
+  cross-validation](https://doi.org/10.1111/geb.12161)
+- [leave-location-out
+  cross-validation](https://doi.org/10.1016/j.envsoft.2017.12.001)
 
 Like [rsample](https://rsample.tidymodels.org/), spatialsample provides
 building blocks for creating and analyzing resamples of a spatial data
@@ -67,11 +67,11 @@ folds
 #> # A tibble: 5 × 2
 #>   splits            id   
 #>   <list>            <chr>
-#> 1 <split [600/82]>  Fold1
-#> 2 <split [589/93]>  Fold2
+#> 1 <split [604/78]>  Fold1
+#> 2 <split [595/87]>  Fold2
 #> 3 <split [524/158]> Fold3
-#> 4 <split [497/185]> Fold4
-#> 5 <split [518/164]> Fold5
+#> 4 <split [490/192]> Fold4
+#> 5 <split [515/167]> Fold5
 ```
 
 In this example, the `boston_canopy` data on tree cover in Boston, MA is
@@ -109,18 +109,18 @@ This project is released with a [Contributor Code of
 Conduct](https://contributor-covenant.org/version/2/1/CODE_OF_CONDUCT.html).
 By contributing to this project, you agree to abide by its terms.
 
--   For questions and discussions about tidymodels packages, modeling,
-    and machine learning, please [post on RStudio
-    Community](https://community.rstudio.com/new-topic?category_id=15&tags=tidymodels,question).
+- For questions and discussions about tidymodels packages, modeling, and
+  machine learning, please [post on RStudio
+  Community](https://community.rstudio.com/new-topic?category_id=15&tags=tidymodels,question).
 
--   If you think you have encountered a bug, please [submit an
-    issue](https://github.com/tidymodels/rules/issues).
+- If you think you have encountered a bug, please [submit an
+  issue](https://github.com/tidymodels/rules/issues).
 
--   Either way, learn how to create and share a
-    [reprex](https://reprex.tidyverse.org/articles/articles/learn-reprex.html)
-    (a minimal, reproducible example), to clearly communicate about your
-    code.
+- Either way, learn how to create and share a
+  [reprex](https://reprex.tidyverse.org/articles/articles/learn-reprex.html)
+  (a minimal, reproducible example), to clearly communicate about your
+  code.
 
--   Check out further details on [contributing guidelines for tidymodels
-    packages](https://www.tidymodels.org/contribute/) and [how to get
-    help](https://www.tidymodels.org/help/).
+- Check out further details on [contributing guidelines for tidymodels
+  packages](https://www.tidymodels.org/contribute/) and [how to get
+  help](https://www.tidymodels.org/help/).
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,21 +1,11 @@
 ## Release Summary
 
-This is the 3rd CRAN release of spatialsample. This release patches some functionality to keep spatialsample aligned with changes in rsample, and now supports simulated data and spatial data without a coordinate reference system.
+This is the 4th CRAN release of spatialsample. This release adds support for repeated cross-validation across all functions, uses edge-to-edge distance for spatially clustered cross-validation, and fixes a few minor bugs.
 
 ## R CMD check results
 
 0 errors | 0 warnings | 1 notes
 
-> checking CRAN incoming feasibility ... NOTE
-  Maintainer: ‘Michael Mahoney <mike.mahoney.218@gmail.com>’
-  
-  New maintainer:
-    Michael Mahoney <mike.mahoney.218@gmail.com>
-  Old maintainer(s):
-    Julia Silge <julia.silge@rstudio.com>
-  
-Michael will be taking over as package maintainer as Julia (who remains as a package author) starts to focus more on the vetiver package and related projects. You'll receive an email confirming this from Julia shortly.
-  
 >  Found the following (possibly) invalid URLs:
     URL: https://doi.org/10.1111/geb.12161
       From: README.md
diff --git a/man/boston_canopy.Rd b/man/boston_canopy.Rd
diff --git a/man/figures/README-2022-06-12_boston-anim-.gif b/man/figures/README-2022-06-12_boston-anim-.gif
diff --git a/man/figures/README-2022-06-12_boston_static-1.png b/man/figures/README-2022-06-12_boston_static-1.png
diff --git a/revdep/.gitignore b/revdep/.gitignore
@@ -0,0 +1,7 @@
+checks
+library
+checks.noindex
+library.noindex
+cloud.noindex
+data.sqlite
+*.html
diff --git a/revdep/README.md b/revdep/README.md
@@ -0,0 +1,29 @@
+# Platform
+
+|field    |value                                                           |
+|:--------|:---------------------------------------------------------------|
+|version  |R version 4.2.2 Patched (2022-11-10 r83330)                     |
+|os       |Ubuntu 22.04.1 LTS                                              |
+|system   |x86_64, linux-gnu                                               |
+|ui       |RStudio                                                         |
+|language |(EN)                                                            |
+|collate  |en_US.UTF-8                                                     |
+|ctype    |en_US.UTF-8                                                     |
+|tz       |America/New_York                                                |
+|date     |2022-12-09                                                      |
+|rstudio  |2022.07.2+576 Spotted Wakerobin (desktop)                       |
+|pandoc   |2.19.2 @ /usr/lib/rstudio/bin/quarto/bin/tools/ (via rmarkdown) |
+
+# Dependencies
+
+|package       |old   |new        |Δ  |
+|:-------------|:-----|:----------|:--|
+|spatialsample |0.2.1 |0.2.1.9000 |*  |
+|globals       |NA    |0.16.2     |*  |
+|rsample       |NA    |1.1.1      |*  |
+|s2            |NA    |1.1.1      |*  |
+|slider        |NA    |0.3.0      |*  |
+|vctrs         |NA    |0.5.1      |*  |
+
+# Revdeps
+
diff --git a/revdep/cran.md b/revdep/cran.md
@@ -0,0 +1,7 @@
+## revdepcheck results
+
+We checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+
+ * We saw 0 new problems
+ * We failed to check 0 packages
+
diff --git a/revdep/email.yml b/revdep/email.yml
@@ -0,0 +1,5 @@
+release_date: ???
+rel_release_date: ???
+my_news_url: ???
+release_version: ???
+release_details: ???
diff --git a/revdep/failures.md b/revdep/failures.md
@@ -0,0 +1 @@
+*Wow, no problems at all. :)*
diff --git a/revdep/problems.md b/revdep/problems.md
@@ -0,0 +1 @@
+*Wow, no problems at all. :)*
