-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fade long channel names in sidebar #75
Conversation
position: absolute; left: 10px; | ||
} | ||
#sidebar .chan:after { | ||
position: absolute; right: 10px; top: 0; bottom: 0; z-index: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One property per line please.
95a2c81
to
0d1905e
Compare
Screenshots? |
Okay, I tried this now, and there's one thing I don't like about it. Even if you delete close button element, the name still doesn't expand past the notification badge. It simply cuts off where the notification badge would be, without any gradient. If you can fix this, that would be nice! |
0d1905e
to
45114d9
Compare
Updated. I don't know where exactly you saw that, but I changed the place where the gradient is applied so the trick is simpler which makes it easier to make look clean. I also made sure to move the badge out of the way by putting it back to position:absolute when it fades away. It should look pretty good now no matter what. |
👍 |
This is pretty awesome, thanks @maxpoulin64 Can you rebase, and check that the new stylelint doesn't break the build for this, and then I'm happy to merge. 👍 |
e8d2adc
to
6f34533
Compare
@YaManicKill Here you go. It did break all over the place, and it didn't merge properly at all either. Ended up just redoing it over master. |
I love it, excellent job @maxpoulin64! I did notice a small issue though: when the name is long, hovering on the name is messing up with the channel closing button (×). I know we mentioned removing it, but it's not the case yet (and it is not sure yet). Here is what I'm talking about (notice the first and third lines): Do you think you could fix this before we merge? :-/ |
6f34533
to
aa46a24
Compare
aa46a24
to
867917f
Compare
After discussing with @maxpoulin64 on IRC, he fixed this and it does look terrific. So 👍 and merging. Also, I'm re-labeling this as a bugfix since currently long channel names are simply not being displayed well: they appear on a second line and get cut at the end of the end of the sidebar. Leaving as enhancement too considering @maxpoulin64 went well beyond duty :-) |
Fade long channel names in sidebar
Fix built-in themes broken by #75.
This uses a few CSS tricks to fade away long channel names in the sidebar so the badge don't overlap on top of the channel names.