Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade long channel names in sidebar #75

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

maxpoulin64
Copy link
Member

This uses a few CSS tricks to fade away long channel names in the sidebar so the badge don't overlap on top of the channel names.

position: absolute; left: 10px;
}
#sidebar .chan:after {
position: absolute; right: 10px; top: 0; bottom: 0; z-index: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One property per line please.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Feb 19, 2016
@maxpoulin64 maxpoulin64 force-pushed the badge-fade branch 3 times, most recently from 95a2c81 to 0d1905e Compare February 19, 2016 22:57
@astorije
Copy link
Member

Screenshots?

@maxpoulin64
Copy link
Member Author

badge

@xPaw
Copy link
Member

xPaw commented Feb 20, 2016

Okay, I tried this now, and there's one thing I don't like about it. Even if you delete close button element, the name still doesn't expand past the notification badge. It simply cuts off where the notification badge would be, without any gradient.

If you can fix this, that would be nice!

@maxpoulin64
Copy link
Member Author

Updated. I don't know where exactly you saw that, but I changed the place where the gradient is applied so the trick is simpler which makes it easier to make look clean. I also made sure to move the badge out of the way by putting it back to position:absolute when it fades away. It should look pretty good now no matter what.

lounge-badge

@xPaw
Copy link
Member

xPaw commented Feb 21, 2016

👍

@AlMcKinlay
Copy link
Member

This is pretty awesome, thanks @maxpoulin64

Can you rebase, and check that the new stylelint doesn't break the build for this, and then I'm happy to merge.

👍

@maxpoulin64 maxpoulin64 force-pushed the badge-fade branch 2 times, most recently from e8d2adc to 6f34533 Compare February 22, 2016 04:55
@maxpoulin64
Copy link
Member Author

@YaManicKill Here you go. It did break all over the place, and it didn't merge properly at all either. Ended up just redoing it over master.

@astorije
Copy link
Member

I love it, excellent job @maxpoulin64!

I did notice a small issue though: when the name is long, hovering on the name is messing up with the channel closing button (×). I know we mentioned removing it, but it's not the case yet (and it is not sure yet). Here is what I'm talking about (notice the first and third lines):

thelounge-fade-badge

Do you think you could fix this before we merge? :-/

@astorije
Copy link
Member

After discussing with @maxpoulin64 on IRC, he fixed this and it does look terrific. So 👍 and merging.

Also, I'm re-labeling this as a bugfix since currently long channel names are simply not being displayed well: they appear on a second line and get cut at the end of the end of the sidebar. Leaving as enhancement too considering @maxpoulin64 went well beyond duty :-)

@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Feb 22, 2016
astorije added a commit that referenced this pull request Feb 22, 2016
Fade long channel names in sidebar
@astorije astorije merged commit 1e8ca51 into thelounge:master Feb 22, 2016
@astorije astorije assigned xPaw and unassigned xPaw Feb 25, 2016
maxpoulin64 added a commit to maxpoulin64/thelounge that referenced this pull request Feb 25, 2016
maxpoulin64 added a commit that referenced this pull request Feb 25, 2016
@maxpoulin64 maxpoulin64 deleted the badge-fade branch March 6, 2016 06:33
@astorije astorije added this to the 1.2.0 milestone Apr 1, 2017
@xPaw xPaw removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants