Get rid of OSX CI builds until they get much faster #707
Conversation
astorije
added
Type: Bug
| @@ -3,12 +3,6 @@ node_js: | |||
| - 6 | |||
| - 4 | |||
|
|
|||
| matrix: | |||
| fast_finish: true | |||
There was a problem hiding this comment.
fast_finish is only applied when there is a build with allowed failures set up. We don't need to keep it if we remove OSX builds.
There was a problem hiding this comment.
Also, OSX builds are always longer than Linux builds, so it would alway fast finish...
There was a problem hiding this comment.
Not only in that case. https://docs.travis-ci.com/user/customizing-the-build/#Fast-Finishing
There was a problem hiding this comment.
Not only in that case. https://docs.travis-ci.com/user/customizing-the-build/#Fast-Finishing
Again, this only applies if there are jobs in the matrix with allowed failures. We actually have none (the OSX one is not even currently marked as allowed-failures, we would need to have an extra line for that).
There was a problem hiding this comment.
There was a problem hiding this comment.
Alright alright alright. But note that if it can be quite a big deal for big projects with long-running builds of multiple jobs (enough to not all run in parallel), it is not even remotely our case on our 2-job-of-1min-something builds...
Clearly splitting hair here but oh well.
OSX builds have been nothing but a pain on Travis CI: they fail with no good reason, they stay pending forever, etc. As far as I can tell, I can't remember one valid build they failed and we legitimately discovered a bug. Dev env on OSX is very close to Linux so it's good enough to have it here.
astorije
force-pushed
the
astorije/rm-rf-osx
branch
from
9ee2a49 to
dec9a17
Compare
Get rid of OSX CI builds until they get much faster
OSX builds have been nothing but a pain on Travis CI: they fail with no good reason, they stay pending forever, etc.
As far as I can tell, I can't remember one valid build they failed and we legitimately discovered a bug. Dev env on OSX is very close to Linux so it's good enough to have it here.
I'm OK with having AppVeyor running slow, which it often does, but Travis CI should be fast and so far this has been the unfortunate bottleneck.