Only update the users list when needed #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -572,6 +585,11 @@ $(function() { | |||
| } | |||
| } | |||
|
|
|||
| if (chan.hasClass("needs-names-refresh")) { | |||
There was a problem hiding this comment.
Can you use data attribute instead?
Currently, for join/part/kick/nick/... the server will send an updated list of users and the client will re-render the list entirely. This ends up being a very expensive operation when joined on large channels and causes the client to slow down a lot.
maxpoulin64
force-pushed
the
userlist-lag
branch
from
8242258 to
5bf2051
Compare
|
👍 |
|
Yep, looks good to me. Merging 👍 |
AlMcKinlay
added a commit
that referenced
this pull request
Feb 19, 2016
Only update the users list when needed
astorije
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for join/part/kick/nick/... the server will send an updated list of users and the client will re-render the list entirely. This ends up being a very expensive operation when joined on large channels and causes the client to slow down a lot.
This patch makes it so the user list is only updated when it is actually visible, avoiding lots and lots of user list re-renders on large channels.