Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save user when parting channels #297

Merged
merged 1 commit into from
May 6, 2016
Merged

Save user when parting channels #297

merged 1 commit into from
May 6, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 6, 2016

Fixes channels persisting in the config even after leaving them.

@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels May 6, 2016
@@ -23,5 +23,9 @@ exports.input = function(network, chan, cmd, args) {
chan: chan.id
});

if (chan.type === "channel") {
this.save();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we put that at line 18 (and I guess moving line 21 above the block lines 16-19 then)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@astorije astorije self-assigned this May 6, 2016
@xPaw xPaw force-pushed the xpaw/save-left-channel branch from eea82e6 to 4585583 Compare May 6, 2016 16:32
@astorije
Copy link
Member

astorije commented May 6, 2016

👍
Minor bugfix: merging.

@astorije astorije merged commit 2fdb462 into master May 6, 2016
@astorije astorije deleted the xpaw/save-left-channel branch May 6, 2016 22:05
@astorije astorije added this to the ★ Next Release milestone May 15, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants