VON color deserialization broke

[katsu6436]

--@server
local color = von.deserialize(von.serialize(Color(255,0,0)))
print(color, version())

https://imgur.com/Xbkdk9O

tested on fresh new copy of a dedicated server with only latest starfallex loaded

[thegrb93]

It never used to work I think. There's not a serialization type specified for color.

[Advers]

No, I have it on good word that it did work in the near past. I believe something did actually change.

[katsu6436]

Aye, I have no idea what would even have caused it. I just loaded in one day and my model loader from file wasn't working properly.

[thegrb93]

Oh, I think its because regular lua tables used to work for color in most cases even if the type wasn't a color.

[thegrb93]

What is erroring now? Maybe we can still make that work.

[katsu6436]

Oh, so it never was typecast to SF Color type in the first place? I'm just passing the results of the de-serialization of multi part "model" files into functions like hologram.setColor, and it worked before.

I've just done this temporary workaround on my libraries for now:

local data = von.deserialize(str)
local c = data.Color
data.Color = Color(c.r,c.g,c.b,c.a)

So you're saying that those functions were actually just being passed regular tables but with the correct key values so it still accepted them? Can we just fix that then, if changing it to be typecast immediately to SF Color after being de-serialized is out of the question?

[thegrb93]

See if this fixes it? #1971

[katsu6436]

Confirm, the original behavior has been restored.