feat: build arm images #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build kept failing for the ARM architecture because npm was hanging: I removed platforms for now until I find a solution. I can't merge this one unless we make sure that the image gets build successfully. |
|
The workflow run/file you linked includes armv7 that shouldn't conflict with arm64, the 64 bit version of ARM. From those logs it looks like arm64 built fine, and the newer platforms run on that architecture. |
|
For reference, I found this issue that seems to describe the same issue above. |
|
Oh I see, I'll merge this one then. |
|
Any way to get a release tagged (or builds rerun on the latest version)? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kutt used to provide arm images for versions before v3. I'm assuming the build works fine because there's an arm version pushed for v3 which seems to be a mistake; but the Dockerfile may need to be adapted if it doesn't support ARM.