Raise minimum python version to 3.8 (esphome#3176)

Author: jesserockz

.github/workflows/ci.yml

@@ -80,7 +80,7 @@ jobs:
         uses: actions/setup-python@v2
         id: python
         with:
-          python-version: '3.7'
+          python-version: '3.8'
 
       - name: Cache virtualenv
         uses: actions/cache@v2

.gitignore

@@ -77,6 +77,7 @@ venv/
 ENV/
 env.bak/
 venv.bak/
+venv-*/
 
 # mypy
 .mypy_cache/

.pre-commit-config.yaml

@@ -25,3 +25,8 @@ repos:
           - --branch=dev
           - --branch=release
           - --branch=beta
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v2.31.0
+    hooks:
+      - id: pyupgrade
+        args: [--py38-plus]

esphome/__main__.py

@@ -778,10 +778,10 @@ def run_esphome(argv):
         _LOGGER.warning("Please instead use:")
         _LOGGER.warning("   esphome %s", " ".join(args.deprecated_argv_suggestion))
 
-    if sys.version_info < (3, 7, 0):
+    if sys.version_info < (3, 8, 0):
         _LOGGER.error(
-            "You're running ESPHome with Python <3.7. ESPHome is no longer compatible "
-            "with this Python version. Please reinstall ESPHome with Python 3.7+"
+            "You're running ESPHome with Python <3.8. ESPHome is no longer compatible "
+            "with this Python version. Please reinstall ESPHome with Python 3.8+"
         )
         return 1
 

esphome/components/lcd_gpio/display.py

@@ -43,7 +43,7 @@ async def to_code(config):
     await lcd_base.setup_lcd_display(var, config)
     pins_ = []
     for conf in config[CONF_DATA_PINS]:
-        pins_.append((await cg.gpio_pin_expression(conf)))
+        pins_.append(await cg.gpio_pin_expression(conf))
     cg.add(var.set_data_pins(*pins_))
     enable = await cg.gpio_pin_expression(config[CONF_ENABLE_PIN])
     cg.add(var.set_enable_pin(enable))

esphome/components/remote_base/__init__.py

@@ -847,7 +847,7 @@ async def rc_switch_raw_action(var, config, args):
         config[CONF_PROTOCOL], args, RCSwitchBase, to_exp=build_rc_switch_protocol
     )
     cg.add(var.set_protocol(proto))
-    cg.add(var.set_code((await cg.templatable(config[CONF_CODE], args, cg.std_string))))
+    cg.add(var.set_code(await cg.templatable(config[CONF_CODE], args, cg.std_string)))
 
 
 @register_binary_sensor(
@@ -868,13 +868,11 @@ async def rc_switch_type_a_action(var, config, args):
         config[CONF_PROTOCOL], args, RCSwitchBase, to_exp=build_rc_switch_protocol
     )
     cg.add(var.set_protocol(proto))
+    cg.add(var.set_group(await cg.templatable(config[CONF_GROUP], args, cg.std_string)))
     cg.add(
-        var.set_group((await cg.templatable(config[CONF_GROUP], args, cg.std_string)))
+        var.set_device(await cg.templatable(config[CONF_DEVICE], args, cg.std_string))
     )
-    cg.add(
-        var.set_device((await cg.templatable(config[CONF_DEVICE], args, cg.std_string)))
-    )
-    cg.add(var.set_state((await cg.templatable(config[CONF_STATE], args, bool))))
+    cg.add(var.set_state(await cg.templatable(config[CONF_STATE], args, bool)))
 
 
 @register_binary_sensor(
@@ -897,13 +895,9 @@ async def rc_switch_type_b_action(var, config, args):
         config[CONF_PROTOCOL], args, RCSwitchBase, to_exp=build_rc_switch_protocol
     )
     cg.add(var.set_protocol(proto))
-    cg.add(
-        var.set_address((await cg.templatable(config[CONF_ADDRESS], args, cg.uint8)))
-    )
-    cg.add(
-        var.set_channel((await cg.templatable(config[CONF_CHANNEL], args, cg.uint8)))
-    )
-    cg.add(var.set_state((await cg.templatable(config[CONF_STATE], args, bool))))
+    cg.add(var.set_address(await cg.templatable(config[CONF_ADDRESS], args, cg.uint8)))
+    cg.add(var.set_channel(await cg.templatable(config[CONF_CHANNEL], args, cg.uint8)))
+    cg.add(var.set_state(await cg.templatable(config[CONF_STATE], args, bool)))
 
 
 @register_binary_sensor(
@@ -932,11 +926,11 @@ async def rc_switch_type_c_action(var, config, args):
     )
     cg.add(var.set_protocol(proto))
     cg.add(
-        var.set_family((await cg.templatable(config[CONF_FAMILY], args, cg.std_string)))
+        var.set_family(await cg.templatable(config[CONF_FAMILY], args, cg.std_string))
     )
-    cg.add(var.set_group((await cg.templatable(config[CONF_GROUP], args, cg.uint8))))
-    cg.add(var.set_device((await cg.templatable(config[CONF_DEVICE], args, cg.uint8))))
-    cg.add(var.set_state((await cg.templatable(config[CONF_STATE], args, bool))))
+    cg.add(var.set_group(await cg.templatable(config[CONF_GROUP], args, cg.uint8)))
+    cg.add(var.set_device(await cg.templatable(config[CONF_DEVICE], args, cg.uint8)))
+    cg.add(var.set_state(await cg.templatable(config[CONF_STATE], args, bool)))
 
 
 @register_binary_sensor(
@@ -959,11 +953,9 @@ async def rc_switch_type_d_action(var, config, args):
         config[CONF_PROTOCOL], args, RCSwitchBase, to_exp=build_rc_switch_protocol
     )
     cg.add(var.set_protocol(proto))
-    cg.add(
-        var.set_group((await cg.templatable(config[CONF_GROUP], args, cg.std_string)))
-    )
-    cg.add(var.set_device((await cg.templatable(config[CONF_DEVICE], args, cg.uint8))))
-    cg.add(var.set_state((await cg.templatable(config[CONF_STATE], args, bool))))
+    cg.add(var.set_group(await cg.templatable(config[CONF_GROUP], args, cg.std_string)))
+    cg.add(var.set_device(await cg.templatable(config[CONF_DEVICE], args, cg.uint8)))
+    cg.add(var.set_state(await cg.templatable(config[CONF_STATE], args, bool)))
 
 
 @register_trigger("rc_switch", RCSwitchTrigger, RCSwitchData)

esphome/components/tuya/climate/__init__.py

@@ -36,31 +36,25 @@ def validate_temperature_multipliers(value):
             or CONF_TARGET_TEMPERATURE_MULTIPLIER in value
         ):
             raise cv.Invalid(
-                (
-                    f"Cannot have {CONF_TEMPERATURE_MULTIPLIER} at the same time as "
-                    f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER} and "
-                    f"{CONF_TARGET_TEMPERATURE_MULTIPLIER}"
-                )
+                f"Cannot have {CONF_TEMPERATURE_MULTIPLIER} at the same time as "
+                f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER} and "
+                f"{CONF_TARGET_TEMPERATURE_MULTIPLIER}"
             )
     if (
         CONF_CURRENT_TEMPERATURE_MULTIPLIER in value
         and CONF_TARGET_TEMPERATURE_MULTIPLIER not in value
     ):
         raise cv.Invalid(
-            (
-                f"{CONF_TARGET_TEMPERATURE_MULTIPLIER} required if using "
-                f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER}"
-            )
+            f"{CONF_TARGET_TEMPERATURE_MULTIPLIER} required if using "
+            f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER}"
         )
     if (
         CONF_TARGET_TEMPERATURE_MULTIPLIER in value
         and CONF_CURRENT_TEMPERATURE_MULTIPLIER not in value
     ):
         raise cv.Invalid(
-            (
-                f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER} required if using "
-                f"{CONF_TARGET_TEMPERATURE_MULTIPLIER}"
-            )
+            f"{CONF_CURRENT_TEMPERATURE_MULTIPLIER} required if using "
+            f"{CONF_TARGET_TEMPERATURE_MULTIPLIER}"
         )
     keys = (
         CONF_TEMPERATURE_MULTIPLIER,
@@ -76,18 +70,14 @@ def validate_active_state_values(value):
     if CONF_ACTIVE_STATE_DATAPOINT not in value:
         if CONF_ACTIVE_STATE_COOLING_VALUE in value:
             raise cv.Invalid(
-                (
-                    f"{CONF_ACTIVE_STATE_DATAPOINT} required if using "
-                    f"{CONF_ACTIVE_STATE_COOLING_VALUE}"
-                )
+                f"{CONF_ACTIVE_STATE_DATAPOINT} required if using "
+                f"{CONF_ACTIVE_STATE_COOLING_VALUE}"
             )
     else:
         if value[CONF_SUPPORTS_COOL] and CONF_ACTIVE_STATE_COOLING_VALUE not in value:
             raise cv.Invalid(
-                (
-                    f"{CONF_ACTIVE_STATE_COOLING_VALUE} required if using "
-                    f"{CONF_ACTIVE_STATE_DATAPOINT} and device supports cooling"
-                )
+                f"{CONF_ACTIVE_STATE_COOLING_VALUE} required if using "
+                f"{CONF_ACTIVE_STATE_DATAPOINT} and device supports cooling"
             )
     return value
 

esphome/components/web_server/__init__.py

@@ -77,11 +77,11 @@ async def to_code(config):
     if CONF_CSS_INCLUDE in config:
         cg.add_define("WEBSERVER_CSS_INCLUDE")
         path = CORE.relative_config_path(config[CONF_CSS_INCLUDE])
-        with open(file=path, mode="r", encoding="utf-8") as myfile:
+        with open(file=path, encoding="utf-8") as myfile:
             cg.add(var.set_css_include(myfile.read()))
     if CONF_JS_INCLUDE in config:
         cg.add_define("WEBSERVER_JS_INCLUDE")
         path = CORE.relative_config_path(config[CONF_JS_INCLUDE])
-        with open(file=path, mode="r", encoding="utf-8") as myfile:
+        with open(file=path, encoding="utf-8") as myfile:
             cg.add(var.set_js_include(myfile.read()))
     cg.add(var.set_include_internal(config[CONF_INCLUDE_INTERNAL]))

esphome/components/wifi/__init__.py

@@ -225,11 +225,11 @@ def _validate(config):
         if CONF_MANUAL_IP in config:
             use_address = str(config[CONF_MANUAL_IP][CONF_STATIC_IP])
         elif CONF_NETWORKS in config:
-            ips = set(
+            ips = {
                 str(net[CONF_MANUAL_IP][CONF_STATIC_IP])
                 for net in config[CONF_NETWORKS]
                 if CONF_MANUAL_IP in net
-            )
+            }
             if len(ips) > 1:
                 raise cv.Invalid(
                     "Must specify use_address when using multiple static IP addresses."

esphome/dashboard/dashboard.py

@@ -733,7 +733,7 @@ def get(self, configuration=None):
         content = ""
         if os.path.isfile(filename):
             # pylint: disable=no-value-for-parameter
-            with open(file=filename, mode="r", encoding="utf-8") as f:
+            with open(file=filename, encoding="utf-8") as f:
                 content = f.read()
         self.write(content)
 

requirements_test.txt

@@ -1,6 +1,7 @@
 pylint==2.12.2
 flake8==4.0.1
 black==22.1.0
+pyupgrade==2.31.0
 pre-commit
 
 # Unit tests

script/build_jsonschema.py

@@ -170,7 +170,7 @@ def get_logger_tags():
     ]
     for x in os.walk(CORE_COMPONENTS_PATH):
         for y in glob.glob(os.path.join(x[0], "*.cpp")):
-            with open(y, "r") as file:
+            with open(y) as file:
                 data = file.read()
                 match = pattern.search(data)
                 if match:

script/ci-custom.py

@@ -281,9 +281,7 @@ def highlight(s):
     ],
 )
 def lint_no_defines(fname, match):
-    s = highlight(
-        "static const uint8_t {} = {};".format(match.group(1), match.group(2))
-    )
+    s = highlight(f"static const uint8_t {match.group(1)} = {match.group(2)};")
     return (
         "#define macros for integer constants are not allowed, please use "
         "{} style instead (replace uint8_t with the appropriate "

script/clang-format

@@ -17,14 +17,14 @@ def run_format(args, queue, lock, failed_files):
     """Takes filenames out of queue and runs clang-format on them."""
     while True:
         path = queue.get()
-        invocation = ['clang-format-11']
+        invocation = ["clang-format-11"]
         if args.inplace:
-            invocation.append('-i')
+            invocation.append("-i")
         else:
-            invocation.extend(['--dry-run', '-Werror'])
+            invocation.extend(["--dry-run", "-Werror"])
         invocation.append(path)
 
-        proc = subprocess.run(invocation, capture_output=True, encoding='utf-8')
+        proc = subprocess.run(invocation, capture_output=True, encoding="utf-8")
         if proc.returncode != 0:
             with lock:
                 print_error_for_file(path, proc.stderr)
@@ -33,45 +33,54 @@ def run_format(args, queue, lock, failed_files):
 
 
 def progress_bar_show(value):
-    return value if value is not None else ''
+    return value if value is not None else ""
 
 
 def main():
     colorama.init()
 
     parser = argparse.ArgumentParser()
-    parser.add_argument('-j', '--jobs', type=int,
-                        default=multiprocessing.cpu_count(),
-                        help='number of format instances to be run in parallel.')
-    parser.add_argument('files', nargs='*', default=[],
-                        help='files to be processed (regex on path)')
-    parser.add_argument('-i', '--inplace', action='store_true',
-                        help='reformat files in-place')
-    parser.add_argument('-c', '--changed', action='store_true',
-                        help='only run on changed files')
+    parser.add_argument(
+        "-j",
+        "--jobs",
+        type=int,
+        default=multiprocessing.cpu_count(),
+        help="number of format instances to be run in parallel.",
+    )
+    parser.add_argument(
+        "files", nargs="*", default=[], help="files to be processed (regex on path)"
+    )
+    parser.add_argument(
+        "-i", "--inplace", action="store_true", help="reformat files in-place"
+    )
+    parser.add_argument(
+        "-c", "--changed", action="store_true", help="only run on changed files"
+    )
     args = parser.parse_args()
 
     try:
-        get_output('clang-format-11', '-version')
+        get_output("clang-format-11", "-version")
     except:
-        print("""
+        print(
+            """
         Oops. It looks like clang-format is not installed. 
         
         Please check you can run "clang-format-11 -version" in your terminal and install
         clang-format (v11) if necessary.
         
         Note you can also upload your code as a pull request on GitHub and see the CI check
         output to apply clang-format.
-        """)
+        """
+        )
         return 1
 
     files = []
-    for path in git_ls_files(['*.cpp', '*.h', '*.tcc']):
+    for path in git_ls_files(["*.cpp", "*.h", "*.tcc"]):
         files.append(os.path.relpath(path, os.getcwd()))
 
     if args.files:
         # Match against files specified on command-line
-        file_name_re = re.compile('|'.join(args.files))
+        file_name_re = re.compile("|".join(args.files))
         files = [p for p in files if file_name_re.search(p)]
 
     if args.changed:
@@ -84,14 +93,16 @@ def main():
         task_queue = queue.Queue(args.jobs)
         lock = threading.Lock()
         for _ in range(args.jobs):
-            t = threading.Thread(target=run_format,
-                                 args=(args, task_queue, lock, failed_files))
+            t = threading.Thread(
+                target=run_format, args=(args, task_queue, lock, failed_files)
+            )
             t.daemon = True
             t.start()
 
         # Fill the queue with files.
-        with click.progressbar(files, width=30, file=sys.stderr,
-                               item_show_func=progress_bar_show) as bar:
+        with click.progressbar(
+            files, width=30, file=sys.stderr, item_show_func=progress_bar_show
+        ) as bar:
             for name in bar:
                 task_queue.put(name)
 
@@ -100,11 +111,11 @@ def main():
 
     except KeyboardInterrupt:
         print()
-        print('Ctrl-C detected, goodbye.')
+        print("Ctrl-C detected, goodbye.")
         os.kill(0, 9)
 
     sys.exit(len(failed_files))
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()