Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: throw an error when ledger flag is passed #341

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

prajjwol
Copy link
Contributor

@prajjwol prajjwol commented Mar 3, 2022

Description

Throw and error when --ledger flag is passed in cli. This is temporary while we have support for the ledger in an immediate future.

Closes: #XXX


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@prajjwol prajjwol requested a review from hanchon March 3, 2022 18:18
@prajjwol prajjwol force-pushed the prajjwol/throw_ledger_error branch from adbc8c3 to 37a65e4 Compare March 3, 2022 18:25
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you add a changelog entry under bug fixes?

@prajjwol prajjwol force-pushed the prajjwol/throw_ledger_error branch from 37a65e4 to fa40a97 Compare March 3, 2022 19:14
@fedekunze fedekunze merged commit 98e2111 into main Mar 3, 2022
@fedekunze fedekunze deleted the prajjwol/throw_ledger_error branch March 3, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants