Skip to content

Improve job throughput of CI workflow for trunk #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tetsuharuohzeki opened this issue Jun 23, 2022 · 2 comments · May be fixed by #31
Open

Improve job throughput of CI workflow for trunk #30

tetsuharuohzeki opened this issue Jun 23, 2022 · 2 comments · May be fixed by #31

Comments

@tetsuharuohzeki
Copy link
Owner

see #28 (comment)

@tetsuharuohzeki
Copy link
Owner Author

By the experiment in #29, I seem our hypothesis is true.

However, we need configure the concurrency group to use that optimization because it use github.ref.
https://github.com/tetsuharuohzeki/fastly-compute-at-edge-template/blob/72c7584d22d224cab55778d36dd2c545daa6e923/.github/workflows/ci.yaml#L9

Our current design caps the workflow concurrency at the top level workflow. So the concurrency group will not conflict.
However, if we remove the top level concurrency group, then the child level concurrency group will be used.

@tetsuharuohzeki tetsuharuohzeki linked a pull request Jun 23, 2022 that will close this issue
@tetsuharuohzeki
Copy link
Owner Author

Our current design caps the workflow concurrency at the top level workflow. So the concurrency group will not conflict. However, if we remove the top level concurrency group, then the child level concurrency group will be used.

I experiment this design at #31 but it cannot resolve this perf issue.

By this design, deploy job is queued after all dependencies are completed. This mean that the lock by the concurrency group by delopy job is registered on that all dependencies are completed.

So if predecessor delays to complete their dependencies, successor will begin to run delopy job ahead of the predecessor. This cannot achieve our intention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant