Fix FE number sort when changing sort order (#626)

constanzauanini · web-flow · commit 5a5568a1f0dd · 2024-08-01T16:40:01.000-03:00
diff --git a/src/components/table/sort.ts b/src/components/table/sort.ts
@@ -2,7 +2,7 @@ export function descendingComparator<T>(a: T, b: T, orderBy: keyof T, order: Sor
   // first attempt to parse into a numeric value and compare
   const numCompare = descendingNumComparator(a, b, orderBy);
   if (numCompare !== null) {
-    return numCompare;
+    return order === 'desc' ? numCompare : numCompare * -1;
   }
 
   // if non-numeric, compare using the javascript built-in compare for this type

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ export function descendingComparator<T>(a: T, b: T, orderBy: keyof T, order: Sor`
`2`	`2`	`// first attempt to parse into a numeric value and compare`
`3`	`3`	`const numCompare = descendingNumComparator(a, b, orderBy);`
`4`	`4`	`if (numCompare !== null) {`
`5`		`- return numCompare;`
	`5`	`+ return order === 'desc' ? numCompare : numCompare * -1;`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`// if non-numeric, compare using the javascript built-in compare for this type`