feat: Support bring your own image #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludwig-mueller
requested review from
surajsbharadwaj and
Beilmann
as code owners
|
/run pipeline |
1 similar comment
|
/run pipeline |
surajsbharadwaj
requested changes
Oct 29, 2024
surajsbharadwaj
changed the title
surajsbharadwaj
requested changes
Oct 30, 2024
surajsbharadwaj
requested changes
Oct 30, 2024
There was a problem hiding this comment.
- Make changes in catalog.json file to expose the variables to UI. Also think if it makes sense to have 3 fields for custom images on UI ? or just 1 field which supports a dictionary or something and then internally you can convert the dictionary to individual objects.. Make a pre-release and import it to UI to get a feel of it. :)
- Minimum tf version must be >=1.9.0 in all versions.tf file
|
/run pipeline |
surajsbharadwaj
requested changes
Oct 31, 2024
There was a problem hiding this comment.
For Quickstart (standard plus VSI) we do not support custom OS image imports. If we do then we should limit it to just one custom image and this image must be given higher priority and used for creating an instance...
We shall discuss on Monday regarding custom image deployment for Quickstart if we need to support it or not.
|
/run pipeline |
…picks up correctly
surajsbharadwaj
requested changes
Nov 14, 2024
surajsbharadwaj
approved these changes
Nov 15, 2024
|
/run pipeline |
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers