Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam-user,iam-assumable-role,iam-assumable-roles,iam-assumable-roles-with-saml tags support #26

Merged

Conversation

salemgolemugoo
Copy link
Contributor

No description provided.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you by any chance add tags support to other IAM resources where they are supported (eg, aws_iam_role)?

@salemgolemugoo
Copy link
Contributor Author

Yep, sure. I'll try to finish this task tomorrow

@salemgolemugoo salemgolemugoo changed the title iam-user tags support iam-user,iam-assumable-role,iam-assumable-roles,iam-assumable-roles-with-saml tags support May 21, 2019
@antonbabenko antonbabenko merged commit 0b6039f into terraform-aws-modules:master Jun 11, 2019
antonbabenko added a commit that referenced this pull request Jun 11, 2019
@antonbabenko
Copy link
Member

Thanks @salemgolemugoo, and sorry for the delay!

This is now part of v1.0.0 which is currently the latest release for Terraform 0.11.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants