-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mixout module #1960
Comments
Sounds great! Free feel to file an PR. Also, our style is a little bit different from the one of core TF so please take a look at https://github.com/tensorflow/addons/blob/master/CONTRIBUTING.md. But no worries, if you find any problem on testing suite or style, just opening an PR first and pinging me. Thank you. BTW, I would say we can place it in |
+1, it would be better if we create a new subclass for it, eg: Dropout |
Same thought. It would be much better if this is implemented as a layer. |
Hey @AakashKumarNain @facaiy @WindQAQ thanks for the suggestions! I'm working on the layer version but then realize it's actually hard since |
Haven't taken a deeper look into the implementation, but we can subclass https://www.tensorflow.org/api_docs/python/tf/keras/layers/Wrapper For |
awesome will look into that! Great thanks! |
Hi @crystina-z |
TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: |
It's an issue switched from tf repo (here) and here is the pending pr I've sent there. According to the reviewer's suggestion, I probably should add the module to here first.
Relevant information
Are you willing to contribute it: yes
Are you willing to maintain it going forward? yes
Is there a relevant academic paper? yes, here
Is there already an implementation in another framework? there is a pytorch version provided by the author, yet I don't think it's merged in the framework.
Was it part of tf.contrib? (if so, where): no
Which API type would this fall under (layer, metric, optimizer, etc.)
custom_ops (since it's categorized under
tensorflow/python/ops/nn_ops
), yet I'm not sure which folder I shall add it to (amongactivation/layer/image/seq2seq/text
)The text was updated successfully, but these errors were encountered: