Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next #900

Merged
merged 8 commits into from
Apr 7, 2022
Merged

next #900

merged 8 commits into from
Apr 7, 2022

Conversation

nowseemee
Copy link
Collaborator

@nowseemee nowseemee commented Feb 23, 2022

Before merging next

  • IMPORTANT dist tag for npm publish is next (lerna docs)
  • new --telekom tokens are available in scale-components.css
  • legacy --scl tokens are still available in scale-components.css
  • CSS scoped variables are correct (match the actual code) in Storybook
  • visual tests include dark mode (and pass)
  • deprecate @telekom/scale-design-tokens package (in gh action?)

Before publishing to npm

  • version number is 3.0.0-beta.100 (local machine at release time)

@render
Copy link

render bot commented Feb 23, 2022

@nowseemee nowseemee mentioned this pull request Feb 24, 2022
60 tasks
@acstll acstll mentioned this pull request Mar 30, 2022
@nowseemee nowseemee marked this pull request as ready for review April 5, 2022 07:58
nowseemee added a commit that referenced this pull request Apr 5, 2022
Co-authored-by: Anna Kuchtin <ak@iconstorm.com>
Co-authored-by: Arturo Castillo Delgado <ac@iconstorm.com>
Co-authored-by: Felix Weber <fw@iconstorm.de>
Co-authored-by: Maomao Meyer-Zhang <maomao.meyer-zhang@telekom.de>
Co-authored-by: Marvin Laubenstein <marvin.laubenstein@telekom.de>
@nowseemee nowseemee closed this Apr 5, 2022
@nowseemee nowseemee reopened this Apr 5, 2022
@render
Copy link

render bot commented Apr 5, 2022

@render
Copy link

render bot commented Apr 5, 2022

@nowseemee nowseemee merged commit 991ed7e into main Apr 7, 2022
@nowseemee nowseemee deleted the next branch April 7, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants