Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css variables inconsistency #742

Merged
merged 13 commits into from
Dec 17, 2021

Conversation

christopherGdynia
Copy link
Contributor

Hello,

as mentioned in #738 there are some inconsistensies with the css variables, I added the css of the first components, this will make it easier to create a custom theme or dark mode.

@acstll
Copy link
Collaborator

acstll commented Dec 15, 2021

@christopherGdynia gonna check with the colleagues before merging, but this looks good to me already! Thank you very much!

@acstll
Copy link
Collaborator

acstll commented Dec 16, 2021

@christopherGdynia could you please run yarn format inside packages/components to fix the prettier check? 🙏 then we can merge :)

@christopherGdynia
Copy link
Contributor Author

@acstll do you have a setup guide for yarn and the project?
I am trying to get it done with npm

@acstll
Copy link
Collaborator

acstll commented Dec 17, 2021

@acstll do you have a setup guide for yarn and the project? I am trying to get it done with npm

oh, sorry I missed your message yesterday. I see you already did it, npm should work more or less the same (npm run format). But I see prettier "prettified" some files that didn't have to do with the PR, this is annoying.

I'm not sure why this happens (different versions of prettier maybe?) but I'm not sure how to fix it now.

Could you please revert the style fix commit (6d56ce2)? I think you do git revert 6d56ce24ff7ad64510eb068f539aee6671ce331e. And then we can merge it despite the original failing check.

Sorry about this 🙏 and thank you!

christopherGdynia and others added 2 commits December 17, 2021 12:00
@acstll acstll merged commit 15af88b into telekom:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants