Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/roundings refactor #691

Merged
merged 45 commits into from
Nov 15, 2021
Merged

Feat/roundings refactor #691

merged 45 commits into from
Nov 15, 2021

Conversation

reld
Copy link
Collaborator

@reld reld commented Nov 11, 2021

Updates the radius value of:

  • packages/components/src/components/data-grid/data-grid.css
  • packages/components/src/components/date-picker/date-picker.css
  • packages/components/src/components/pagination/pagination.css
  • packages/components/src/components/table/table.css
  • packages/components/src/components/telekom/app-footer/app-footer.css
    Adds new date picker include file:
  • packages/generator-sketch/includes/scale-date-picker.inc.sketch
  • packages/generator-sketch/sketch/symbol_database.sqlite

oddcelot and others added 26 commits September 16, 2021 17:26
@oddcelot
chore: autoformat
5f3b212
@oddcelot
feat(tokens): add token for bigger radius
6d887ec
@oddcelot
chore: add radius tokens to missing places
09c2b61
@oddcelot
refactor(tokens): add radius-12 definitions
7ef06f1
@oddcelot
refactor(tokens): add radius-8 definitions
a591d9a
@oddcelot
chore: update storybook assets with updated rouding token
25e967c
@oddcelot
refactor(tokens): add radius-12 to card
e9aa7b7
@oddcelot
chore: update icon color in sketch build
434334b
@oddcelot
chore: update sketch includes
9f80ab8
@oddcelot
chore: add tab nav disabled stae for sketch
68e066f
@oddcelot
refactor(table): increase last cell padding
4fe3e0f
@oddcelot
chore: update sketch symbol DB
60ba8be
@oddcelot
fix(sketch): selected radio button reference for hover state
8da6443
@oddcelot
refactor(table): adjust tfoot padding
04635f6
@oddcelot
chore(sketch): remove focus/active states from radio button
4448eb0
@oddcelot
refactor(footer): set border-radius to new token
8a06dc2
@oddcelot
chore: update modal story assets
97d7631
@oddcelot
refactor(sketch): change sketch include pattern
edddd96
@oddcelot
chore(storybook): change card images
4deab04
@oddcelot
chore: change storybook assets
799f38c
@oddcelot
chore: update text input assets
255adf6
@reld
feat: add include sktech files with new rounding values
d98b741
@reld
feat: generator-sketch sqlite db update
145732a
@reld
feat: merge main
81f2875 
merge latest code into the rounding refactor branch
@reld
refactor: brings latest code from main into the roundings refactor br…
04ae2fc 
…anch
@reld
feat: adjusts the right radii values for different components
11d917b
@reld reld requested a review from nowseemee as a code owner November 11, 2021 14:33
@render
Copy link

render bot commented Nov 11, 2021

Your Render PR Server URL is https://scale-storybook-staging-pr-691.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c66ijgfs437m99t18hl0.

reld and others added 17 commits November 11, 2021 17:22
@reld
fix: removes sketch file duplicate
82b0494
@reld
feat: add new date picker sketch file
bdb1ff6
@reld
fix: fix position for checkbox and radio symbols to top left
a3deeb7
@reld
docs: updates stories and images for data table and date picker compo…
e1c70bd 
…nents
@reld
chore: reformat files
6372198
@reld
feat: updates roundings
c918395
@reld
feat: rebuild sketch lib with new roundings values
617b895
@reld
docs: updates design updates stories
7aa9566
@reld
docs: reformat files
533d570
@reld
docs: updates date picker elements picture for story
ccb4d9a
@reld
docs: add links to updated components stories
e89b975
@reld
docs: add linebreaks to design updates stories
d106f2f
@reld
docs: get affected times sentence out of the list to respect line breaks
556ee34
@reld
docs: reformat
4bc8e50
@reld
Merge branch 'main' into feat/roundings-refactor
a0bfec4
@nowseemee
test(roundings): update visual snapshots
7ec0e41
@nowseemee
Merge branch 'main' into feat/roundings-refactor
c7fa755
@nowseemee nowseemee merged commit f03a762 into main Nov 15, 2021
@nowseemee nowseemee deleted the feat/roundings-refactor branch November 15, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reld @nowseemee @oddcelot