feat: changes for adding list attribute to the scale text field.

[gaurishkamat]

No description provided.

[gaurishkamat]

Hi @acstll,
Created a new PR with suggested changes. Could you please have a look whenever you are free.

Thanks!

[acstll]

There is some code we don't need and some that can be simplified, I left some comments.

Thank you for the quick response!

[acstll]

@gaurishkamat some checks are not passing, could you be so kind and try and fix those?

• for the prettier check you can run yarn format (in the root or in packages/components)
• for the e2e-tests check make sure the e2e tests pass, run them with yarn test --e2e inside packages/components
• for the uncommitted-changes check, you need to run yarn build in packages/components (it will update the text-field/readme.md file automatically, those readme files are auto-generated)

Thanks again 🙏

[gaurishkamat]

Thanks for the much needed detailed explanation @acstll. I have completed the above mentioned steps, let me know if anything is pending.

[gaurishkamat]

@acstll not sure why the checks are failing.

[acstll]

@acstll not sure why the checks are failing.

me neither.

e2e pass locally for me. And yarn build generates a couple of readme.md files, but they're OK in main and your branch is up-to-date with main, so it's indeed weird.

Since e2e tests pass locally and the uncommitted changes seem to be OK too. I will merge.

Thanks a lot again for your contribution.

[gaurishkamat]

Hi @acstll should this be working for scale-components-react as well or we need some more changes?

[acstll]

It should, the React package is automatically generated. Does it work? the latest 3.0.0-beta.17 should have it.