Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button #282

Merged
merged 2 commits into from
Apr 28, 2021
Merged

fix: button #282

merged 2 commits into from
Apr 28, 2021

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Apr 28, 2021

  • prevent the button from emitting click events when disabled
  • add unit test (missing, but 🆗)
  • add missing --width scoped variables (bonus ✨)

the "click event fired when disabled" issue is not reproducible in Storybook, and I'm 99% sure that's because of the "Vue layer" — I think we should consider —proudly— switching to a WC-only Storybook

@acstll acstll requested a review from nowseemee April 28, 2021 02:32
@acstll acstll self-assigned this Apr 28, 2021
@acstll acstll requested a review from eeegor as a code owner April 28, 2021 02:32
@nowseemee nowseemee merged commit d82a02f into main Apr 28, 2021
@nowseemee nowseemee deleted the fix/button-disabled-click branch April 28, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

@eeegor eeegor Awaiting requested review from eeegor

Assignees

@acstll acstll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acstll @nowseemee