Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding possibility to use a tags with scale-link inside breadcrumbs #1089

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

marvinLaubenstein
Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein commented Jun 1, 2022

fix: is not compatible with #1016

@acstll (we talked about this before at Basecamp)

@render
Copy link

render bot commented Jun 1, 2022

@marvinLaubenstein marvinLaubenstein linked an issue Jun 30, 2022 that may be closed by this pull request
@marvinLaubenstein marvinLaubenstein requested review from acstll and removed request for acstll and nowseemee June 30, 2022 06:52
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marvinLaubenstein thanks for this!

Just to make sure I get it correctly, this is "partial" fix, because using scale-link inside the breadcrumbs components will render an actual link (not a span), but the styles won't match the ones from scale-link, correct?

@marvinLaubenstein
Copy link
Collaborator Author

Thanks for reviewing @acstll .

Yes exactly, the solution is first of all a nice to have, so that users can use scale-links in the scale-breadcrumb and not automatically a span arise although you wanted a link.

Final solution, which unfortunately has not yet been clarified, would of course be to remove the a tag and replace it with our scale-link

@marvinLaubenstein marvinLaubenstein merged commit 8b44a3b into main Jul 5, 2022
@marvinLaubenstein marvinLaubenstein deleted the refactor/breadcrumb branch July 5, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<scale-link> is not compatible with <scale-breadcrumb>
2 participants