Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Message and Notification Banner don't emit scale-close Event #1057

Closed
lukascorona opened this issue May 16, 2022 · 2 comments
Closed
Assignees
Labels
feature New component features and enhancements

Comments

@lukascorona
Copy link

Describe the feature request
Currently, unlike the scale-modal, no scale-close event is emitted when the close button is clicked. Here it would be desirable that a corresponding event is emitted so that a controlled underlying state can be updated accordingly.

Describe the use case
We want to use the scale-notification-message to display notifications that get stored locally. However, when clicking the close icon, we need to mark them as read so that they are not displayed again when the page is reloaded.

Describe alternatives you've considered
As an alternative, a slot for a custom close button could be provided. Consistent event emitting similar to the scale-modal would certainly be more understandable though

Additional context
image
The image shows our planned usage for the notifications. A click on the close button should permanently delete the respective notification from the quick menu

@lukascorona lukascorona added the feature New component features and enhancements label May 16, 2022
@acstll
Copy link
Collaborator

acstll commented May 17, 2022

I would be in favor also of emitting scale-close 👍 — thanks for opening this @lukascorona

@nowseemee
Copy link
Collaborator

3.0.0-beta.105 has this addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New component features and enhancements
Projects
None yet
Development

No branches or pull requests

4 participants