Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta features in V1 for Integration and Examples Test #5706

Closed
JeromeJu opened this issue Nov 1, 2022 · 3 comments
Closed

Beta features in V1 for Integration and Examples Test #5706

JeromeJu opened this issue Nov 1, 2022 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 1, 2022

Feature request

The beta feature in V1 needs to be specified. The respective flag values and directories need to be updated.

  • feature flag table & gates
  • plumbing for beta feature tests

(please feel free to edit if missing)

Use case

In #5579 , the integration tests for bundle conversion to resolver needs beta/ alpha feature flags to be set.

For example, the following tests are failing in v1 examples without feature flags for non-alpha integration test.
https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5579/pull-tekton-pipeline-integration-tests/1587456476048265216

@JeromeJu JeromeJu added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2022
@JeromeJu
Copy link
Member Author

JeromeJu commented Nov 1, 2022

/assign

@JeromeJu JeromeJu changed the title Beta features in V1 Examples Beta features in V1 for Integration and Examples Test Nov 1, 2022
@JeromeJu
Copy link
Member Author

JeromeJu commented Nov 1, 2022

Thanks to the pointers from Dibyo, our existing pull-tekton-pipeline-alpha-integration-tests could run with beta flags set.
Does it makes sense to ask the question 'Will this lead to the creation of beta-integration test'?
cc @lbernick @dibyom

Currently trying to figure out the prow env for .examples/v1beta1/pipelineruns/alpha

@lbernick
Copy link
Member

I think this is a duplicate of #5734?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

No branches or pull requests

2 participants