fix: dissoc-in creating maps for missing paths

Fix an issue where `dissoc-in` could create nested maps on the way down.
Now, if the path doesn't exist we don't traverse further.

Author: rschmukler

src/wing/core.cljc

@@ -407,11 +407,12 @@
 (defn dissoc-in
   "Like `clojure.core/dissoc` but takes a path like `clojure.core/get-in`"
   [m path]
-  (let [path-count (count path)]
-    (if (= 1 path-count)
-      (dissoc m (first path))
-      (let [[update-tgt [dissoc-tgt]] (split-at (- path-count 1) path)]
-        (update-in m update-tgt dissoc dissoc-tgt)))))
+  (let [[k & ks] path]
+    (cond
+      (or (empty? path)
+          (not (contains? m k))) m
+      (empty? ks)                (dissoc m k)
+      :else                      (update m k dissoc-in ks))))
 
 (defn index-by
   "Indexes a `coll` by the value returned by `f`. Returns a map.
@@ -570,7 +571,6 @@
                 (#?(:clj .removeFirst :cljs .shift) a))
               (rf result v))
             result)))))))
-
 (comment
   (toggle #{:a :b} :c)
   (toggle #{:a :b} :b)

test/wing/core_test.cljc

@@ -8,14 +8,19 @@
 
 (def gen-simple-map
   "Generator for simple map"
-  (let [simple-gen (gen/one-of [gen/keyword gen/int gen/string gen/boolean])
+  (let [simple-gen (gen/one-of [gen/keyword gen/small-integer gen/string gen/boolean])
         simple-val (gen/frequency [[5 simple-gen]
                                    [1 (gen/map simple-gen simple-gen)]
                                    [1 (gen/list simple-gen)]
                                    [1 (gen/vector simple-gen)]
                                    [1 (gen/set simple-gen)]])]
     (gen/map simple-gen simple-val)))
 
+(deftest assert-info-test
+  (is (thrown?
+        #?(:clj clojure.lang.ExceptionInfo :cljs js/Error)
+        (sut/assert-info (= 1 2) "Non-sense error" {:foo :bar}))))
+
 (deftest deep-merge-test
   (testing "is identity for single arguments"
     (is (= 3 (sut/deep-merge 3)))
@@ -46,7 +51,7 @@
 
 (defspec apply-if-applies-if-pred-returns-true
   5
-  (prop/for-all [x gen/int]
+  (prop/for-all [x gen/small-integer]
       (is (= (inc x)
              (sut/apply-if x (constantly true) inc)))))
 
@@ -58,7 +63,7 @@
 
 (defspec apply-when-applies-if-pred-returns-true
   5
-  (prop/for-all [x gen/int]
+  (prop/for-all [x gen/small-integer]
       (is (= (inc x)
              (sut/apply-when x (constantly true) inc)))))
 
@@ -457,7 +462,10 @@
                                 :h 9}}]
       (is (= {:a 1 :b 2 :c 3 :d {:e {:g true}
                                  :h 9}}
-             (sut/dissoc-in m [:d :e :f]))))))
+             (sut/dissoc-in m [:d :e :f])))))
+  (testing "does not alter maps for paths that don't exist"
+    (let [m {:a 1 :b 2}]
+      (is (= m (sut/dissoc-in m [:c :d]))))))
 
 (deftest index-by-test
   (let [data [{:name "Bob" :age 42}
@@ -510,6 +518,7 @@
       (is (= '(1
                 3
                 5)
+             #_{:clj-kondo/ignore [:deprecated-var]}
              (sut/unfold f 1))))))
 
 (deftest arity-test
@@ -538,6 +547,7 @@
              (sut/make-map "a" a b))))))
 
 (deftest random-uuid-test
+  #_{:clj-kondo/ignore [:deprecated-var]}
   (is (uuid? (sut/random-uuid))))
 
 (deftest compr-test
@@ -578,3 +588,6 @@
                  coll (gen/vector gen/small-integer 1 50)]
       (is (= (partition size step nil coll)
              (sequence (sut/sliding size step) coll)))))
+
+(deftest deep-merge*-test
+  (is (= 1 1)))