Closes #53 - incorrect container selection (#55)

* fix(app): #53 fix pointer issue which was overwriting tasks in map

* chore(opts): remove unecessary enable-env param now that we can configure using env vars

* chore(workflow): fix goreleaser build with skip publish arg

Author: tedsmitt

.github/workflows/test.yml

@@ -35,7 +35,7 @@ jobs:
         uses: goreleaser/goreleaser-action@v6
         with:
           version: latest
-          args: --snapshot --skip-publish --clean
+          args: --snapshot --skip=publish --clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           HOMEBREW_TAP_GITHUB_TOKEN: ${{ secrets.HOMEBREW_TAP_GITHUB_TOKEN }}

cmd/main.go

@@ -101,7 +101,6 @@ func init() {
 	rootCmd.PersistentFlags().StringP("local-port", "l", "", "Local port for use with port forwarding")
 	rootCmd.PersistentFlags().BoolP("quiet", "q", false, "Do not print cluster and container information")
 	rootCmd.PersistentFlags().StringP("aws-endpoint-url", "e", "", "AWS Endpoint Url")
-	rootCmd.PersistentFlags().BoolP("enable-env", "v", false, "Enable ENV population of cli args")
 
 	viper.BindPFlag("cmd", rootCmd.PersistentFlags().Lookup("cmd"))
 	viper.BindPFlag("profile", rootCmd.PersistentFlags().Lookup("profile"))

internal/app.go

@@ -393,8 +393,9 @@ func (e *App) getTask() {
 		}
 
 		for _, t := range describe.Tasks {
+			task := t
 			taskId := strings.Split(*t.TaskArn, "/")[2]
-			e.tasks[taskId] = &t
+			e.tasks[taskId] = &task
 		}
 
 		selection, err := selectTask(e.tasks)