sql.DateTime data type does not cast as per sql.DateTime2

[agarstang]

Copying #185 from node-mssql.

days = Math.floor((parameter.value.getTime() - UTC_EPOCH_DATE.getTim
                                    ^
TypeError: undefined is not a function

In data-type.js you have missed to convert date string to object as you have done for DateTime2

if (parameter.value != null) {
      parameter.value = new Date(+parameter.value);  // this line is missing
       if (options.useUTC) {

[arthurschreiber]

The way we do type conversion in tedious is a mess, and really inconsistent.

I think this here is an actual bug (because it's raising a TypeError), and that's bad and needs to be fixed. But I'm not sure what a "good" fix is going to look like.

Long term (in tedious@3.x or even later), I want us to move away from doing any type conversion at all - if your application defines a parameter to be a DateTime, it should be your application's responsibility to pass a Date object and not a String or something else. And if you want to make use of SQLServer's type conversion, you should've specified a String parameter anyway.

[arthurschreiber]

/cc @chdh Because I think he might be interested in this discussion.

[chdh]

@arthurschreiber

I want us to move away from doing any type conversion at all

This answers my question in #623.
What do you think about conversion from float to integer (same data type in JS, but not in SQL Server)? I think it's better not to convert at all and just verify that it's an integer number.

Long term (in tedious@3.x or even later),

I think it's not such a big change and it's important. I could write a PR if you like.

[arthurschreiber]

I think it's not such a big change and it's important. I could write a PR if you like.

It's a backwards incompatible change if we stop converting these values, so it should be a major version bump. We should not be afraid of major version bumps. 😄