Fix assertion in PosixRandomAccessFile

igorcanadi · igorcanadi · commit d9c0785812ee · 2014-08-26T15:28:36.000-04:00
Summary: See facebook/rocksdb#244 (comment) Also see this: https://github.com/facebook/rocksdb/blob/master/util/env_posix.cc#L1075 Test Plan: compiles Reviewers: yhchiang, ljin, sdong Reviewed By: ljin Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D22419
diff --git a/util/env_posix.cc b/util/env_posix.cc
@@ -231,7 +231,7 @@ class PosixRandomAccessFile: public RandomAccessFile {
   PosixRandomAccessFile(const std::string& fname, int fd,
                         const EnvOptions& options)
       : filename_(fname), fd_(fd), use_os_buffer_(options.use_os_buffer) {
-    assert(!options.use_mmap_reads);
+    assert(!options.use_mmap_reads || sizeof(void*) < 8);
   }
   virtual ~PosixRandomAccessFile() { close(fd_); }
 

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ class PosixRandomAccessFile: public RandomAccessFile {`
`231`	`231`	`PosixRandomAccessFile(const std::string& fname, int fd,`
`232`	`232`	`const EnvOptions& options)`
`233`	`233`	`: filename_(fname), fd_(fd), use_os_buffer_(options.use_os_buffer) {`
`234`		`- assert(!options.use_mmap_reads);`
	`234`	`+ assert(!options.use_mmap_reads \|\| sizeof(void*) < 8);`
`235`	`235`	`}`
`236`	`236`	`virtual ~PosixRandomAccessFile() { close(fd_); }`
`237`	`237`