table/bloom_block.*: pass func parameter by reference

dalgaaf · dalgaaf · commit 8ce050b51b1a · 2014-09-30T23:30:31.000+02:00
[table/bloom_block.h:29]: (performance) Function parameter
 'keys_hashes' should be passed by reference.

Signed-off-by: Danny Al-Gaaf &lt;danny.al-gaaf@bisect.de&gt;
diff --git a/table/bloom_block.cc b/table/bloom_block.cc
@@ -11,7 +11,7 @@
 
 namespace rocksdb {
 
-void BloomBlockBuilder::AddKeysHashes(const std::vector<uint32_t> keys_hashes) {
+void BloomBlockBuilder::AddKeysHashes(const std::vector<uint32_t>& keys_hashes) {
   for (auto hash : keys_hashes) {
     bloom_.AddHash(hash);
   }
diff --git a/table/bloom_block.h b/table/bloom_block.h
@@ -26,7 +26,7 @@ class BloomBlockBuilder {
 
   uint32_t GetNumBlocks() const { return bloom_.GetNumBlocks(); }
 
-  void AddKeysHashes(const std::vector<uint32_t> keys_hashes);
+  void AddKeysHashes(const std::vector<uint32_t>& keys_hashes);
 
   Slice Finish();
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace rocksdb {`
`13`	`13`
`14`		`-void BloomBlockBuilder::AddKeysHashes(const std::vector<uint32_t> keys_hashes) {`
	`14`	`+void BloomBlockBuilder::AddKeysHashes(const std::vector<uint32_t>& keys_hashes) {`
`15`	`15`	`for (auto hash : keys_hashes) {`
`16`	`16`	`bloom_.AddHash(hash);`
`17`	`17`	`}`