Skip to content

Commit 703c3ea

Browse files
author
Lei Jin
committed
comments about the BlockBasedTableOptions migration in Options
Summary: as title Test Plan: none Reviewers: sdong, igor Reviewed By: igor Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D22737
1 parent 4b5ad88 commit 703c3ea

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

include/rocksdb/options.h

+16-2
Original file line numberDiff line numberDiff line change
@@ -409,10 +409,24 @@ struct ColumnFamilyOptions {
409409
std::shared_ptr<MemTableRepFactory> memtable_factory;
410410

411411
// This is a factory that provides TableFactory objects.
412-
// Default: a factory that provides a default implementation of
413-
// Table and TableBuilder.
412+
// Default: a block-based table factory that provides a default
413+
// implementation of TableBuilder and TableReader with default
414+
// BlockBasedTableOptions.
414415
std::shared_ptr<TableFactory> table_factory;
415416

417+
// Block-based table related options are moved to BlockBasedTableOptions.
418+
// Related options that were originally here but now moved include:
419+
// no_block_cache
420+
// block_cache
421+
// block_cache_compressed
422+
// block_size
423+
// block_size_deviation
424+
// block_restart_interval
425+
// filter_policy
426+
// whole_key_filtering
427+
// If you'd like to customize some of these options, you will need to
428+
// use NewBlockBasedTableFactory() to construct a new table factory.
429+
416430
// This option allows user to to collect their own interested statistics of
417431
// the tables.
418432
// Default: empty vector -- no user-defined statistics collection will be

0 commit comments

Comments
 (0)