test(node-bindings): add unit tests for node-bindings utils and refac (alloy-rs#1637)

Author: tcoratger

crates/node-bindings/Cargo.toml

@@ -31,3 +31,4 @@ url.workspace = true
 
 [dev-dependencies]
 ci_info.workspace = true
+tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }

crates/node-bindings/src/utils.rs

@@ -59,13 +59,9 @@ pub(crate) fn extract_value<'a>(key: &str, line: &'a str) -> Option<&'a str> {
 
 /// Extracts the endpoint from the given line.
 pub(crate) fn extract_endpoint(key: &str, line: &str) -> Option<SocketAddr> {
-    let val = extract_value(key, line)?;
-
-    // Remove the "Some( ... )" wrapper if it exists
-    let val =
-        if val.starts_with("Some(") && val.ends_with(')') { &val[5..val.len() - 1] } else { val };
-
-    val.parse::<SocketAddr>().ok()
+    extract_value(key, line)
+        .map(|val| val.trim_start_matches("Some(").trim_end_matches(')'))
+        .and_then(|val| val.parse().ok())
 }
 
 /// Runs the given closure with a temporary directory.
@@ -90,23 +86,67 @@ where
     temp_dir.close().unwrap();
 }
 
-#[test]
-fn test_extract_http_address() {
-    let line = "INFO [07-01|13:20:42.774] HTTP server started                      endpoint=127.0.0.1:8545 auth=false prefix= cors= vhosts=localhost";
-    assert_eq!(extract_endpoint("endpoint=", line), Some(SocketAddr::from(([127, 0, 0, 1], 8545))));
-}
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use std::net::SocketAddr;
 
-#[test]
-fn test_extract_udp_address() {
-    let line = "Updated local ENR enr=Enr { id: Some(\"v4\"), seq: 2, NodeId: 0x04dad428038b4db230fc5298646e137564fc6861662f32bdbf220f31299bdde7, signature: \"416520d69bfd701d95f4b77778970a5c18fa86e4dd4dc0746e80779d986c68605f491c01ef39cd3739fdefc1e3558995ad2f5d325f9e1db795896799e8ee94a3\", IpV4 UDP Socket: Some(0.0.0.0:30303), IpV6 UDP Socket: None, IpV4 TCP Socket: Some(0.0.0.0:30303), IpV6 TCP Socket: None, Other Pairs: [(\"eth\", \"c984fc64ec0483118c30\"), (\"secp256k1\", \"a103aa181e8fd5df651716430f1d4b504b54d353b880256f56aa727beadd1b7a9766\")], .. }";
-    assert_eq!(
-        extract_endpoint("IpV4 TCP Socket: ", line),
-        Some(SocketAddr::from(([0, 0, 0, 0], 30303)))
-    );
-}
+    #[test]
+    fn test_extract_value_with_equals() {
+        let line = "key=value some other text";
+        assert_eq!(extract_value("key", line), Some("value"));
+    }
+
+    #[test]
+    fn test_extract_value_with_colon() {
+        let line = "key: value, more text here";
+        assert_eq!(extract_value("key", line), Some("value"));
+    }
+
+    #[test]
+    fn test_extract_value_not_found() {
+        let line = "unrelated text";
+        assert_eq!(extract_value("key", line), None);
+    }
 
-#[test]
-fn test_unused_port() {
-    let port = unused_port();
-    assert!(port > 0);
+    #[test]
+    fn test_extract_http_address() {
+        let line = "INFO [07-01|13:20:42.774] HTTP server started                      endpoint=127.0.0.1:8545 auth=false prefix= cors= vhosts=localhost";
+        assert_eq!(
+            extract_endpoint("endpoint=", line),
+            Some(SocketAddr::from(([127, 0, 0, 1], 8545)))
+        );
+    }
+
+    #[test]
+    fn test_extract_udp_address() {
+        let line = "Updated local ENR enr=Enr { id: Some(\"v4\"), seq: 2, NodeId: 0x04dad428038b4db230fc5298646e137564fc6861662f32bdbf220f31299bdde7, signature: \"416520d69bfd701d95f4b77778970a5c18fa86e4dd4dc0746e80779d986c68605f491c01ef39cd3739fdefc1e3558995ad2f5d325f9e1db795896799e8ee94a3\", IpV4 UDP Socket: Some(0.0.0.0:30303), IpV6 UDP Socket: None, IpV4 TCP Socket: Some(0.0.0.0:30303), IpV6 TCP Socket: None, Other Pairs: [(\"eth\", \"c984fc64ec0483118c30\"), (\"secp256k1\", \"a103aa181e8fd5df651716430f1d4b504b54d353b880256f56aa727beadd1b7a9766\")], .. }";
+        assert_eq!(
+            extract_endpoint("IpV4 TCP Socket: ", line),
+            Some(SocketAddr::from(([0, 0, 0, 0], 30303)))
+        );
+    }
+
+    #[test]
+    fn test_unused_port() {
+        let port = unused_port();
+        assert!(port > 0);
+    }
+
+    #[test]
+    fn test_run_with_tempdir_sync() {
+        run_with_tempdir_sync("test_prefix", |path| {
+            assert!(path.exists(), "Temporary directory should exist");
+            assert!(path.is_dir(), "Temporary directory should be a directory");
+        });
+    }
+
+    #[tokio::test]
+    async fn test_run_with_tempdir_async() {
+        run_with_tempdir("test_prefix", |path| async move {
+            assert!(path.exists(), "Temporary directory should exist");
+            assert!(path.is_dir(), "Temporary directory should be a directory");
+        })
+        .await;
+    }
 }