-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallbacks to DefaultMergeCalendarFields should be removed (or made unconditional) #2463
Comments
Didn't we just decide this yesterday already in #2310? |
The decision of #2310 requires the presence of (w.l.o.g.) |
I would say that's covered by #1808, the builtin-calendars-are-strings behaviour would imply option (2). |
I don't think that implication holds because built-in calendar instances will presumably always inherit from |
This has been addressed somewhere along the line, probably by #2519. The fallback does not exist anymore. |
CalendarMergeFields looks up a
mergeFields
method on its input calendar instance to invoke, but substitutes use of the DefaultMergeCalendarFields operation if no value is found.mergeFields
itself exists onTemporal.Calendar.prototype
in the primordial state, thinly wrapping DefaultMergeCalendarFields in the absence of ECMA-402 and extended in ECMA-402 to include built-in support for non-ISO-8601 calendars.This has the net effect of
delete Temporal.Calendar.prototype.mergeFields
continuing to "work" but removing built-in calendar-sensitive behavior, which a) bad in its own right, and b) divergent from similar manipulation of other built-in methods (e.g., CalendarDateFromFields unconditionally invokesdateFromFields
and will therefore fail if the built-in method is removed).I see two general options for resolution:
I think option 2 would be most consistent with the push in #1808 to minimize action at a distance.
The text was updated successfully, but these errors were encountered: