-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for -u-fw and other Unicode extensions that could impact the result #68
Comments
This issue, if put into the proposal, would mean we also have to
|
Would like to see this as a normative PR in the July TG1 meeting. |
IIRC you actually get Tuesday starting with ICU 73 (ICU-22226), assuming the input locale is passed as-is to ICU. Addressing #30 should help to clarify how Unicode extension tags are handled. |
So I will add a new getter 1.4.X get Intl.Locale.prototype.firstDayOfWeek that will return one of the 7 possible values |
I think this request surface yet another problem in our current spec in the firstDay field as a single value and in the weekend as an array (usually 2 values) But since we are now need to add a getter firstDayOfWeek to return string <<"sun", "mon", "tue", "wed", "thu", "fri", "sat">> |
This issue and #70 was presented to TC39 in July 12, 2023 meeting and does NOT reach consensus for the proposed changes. Here are my understanding of the part which reach consensus: But there are disagreement during July 12 TC39 about Option A (as in the current state (July 11, 2023) of PR70)I. Intl.Locale.prototype.firstDayOfWeek returns: <<undefined, "mon", "tue", "wed", "thu", "fri", "sat", "sun">> Option B (as mentioned in the TC39)I. Intl.Locale.prototype.firstDayOfWeek returns: <<undefined, 1, 2, 3, 4, 5, 6, 7>> Option C (Also mentioned in the TC39)I. Intl.Locale.prototype.firstDayOfWeek returns: <<undefined, 1, 2, 3, 4, 5, 6, 7>> Option DI. Intl.Locale.prototype.firstDayOfWeek returns: <<undefined, 1, 2, 3, 4, 5, 6, 7>> Option EI. Intl.Locale.prototype.firstDayOfWeek returns: <<undefined, 1, 2, 3, 4, 5, 6, 7>> Option C and Option E consider the fact that Date.prototype.getDay ( ) return 0, but not 7, for Sunday. |
Most people after TG2 2023-09-07 meeting unofficially support Option C |
This issue is addressed by PR70 after TC39 on 2023-09 which is option C. However, it cause issue in #78 and we now plan to revert from option C I plan to change the spect to the following: |
Propose fix in #79 |
sorry, this is not right. I need to rework on this. Intl.Locale.prototype.firstDayOfWeek need to return string, but not just that 7 string values. |
Related: #30, tc39/ecma402#580
If I write
then I should get that the first day is Tuesday, but it currently ignores the
-u-fw
.The text was updated successfully, but these errors were encountered: