fix(windows): Ignore resize event when minimizing frameless windows #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I want to know @amrbashir 's feedback. |
amrbashir
requested changes
Mar 24, 2023
src/webview/webview2/mod.rs
Outdated
Comment on lines
749
to
757
| if wparam == WPARAM(win32wm::SIZE_MINIMIZED as _) { | ||
| let _ = (*controller).SetIsVisible(false); | ||
| let _ = controller.SetIsVisible(false); | ||
| } | ||
|
|
||
| if wparam == WPARAM(win32wm::SIZE_RESTORED as _) | ||
| || wparam == WPARAM(win32wm::SIZE_MAXIMIZED as _) | ||
| { | ||
| let _ = (*controller).SetIsVisible(true); | ||
| let _ = controller.SetIsVisible(true); | ||
| } |
There was a problem hiding this comment.
revert all the changes and just remove the visibility handling, and it should be good. This doesn't need to be only for frameless windows.
amrbashir
requested changes
Mar 24, 2023
amrbashir
approved these changes
Mar 24, 2023
Merged
amrbashir
pushed a commit
that referenced
this pull request
Apr 18, 2023
…909) * fix(windows): Do not toggle webview visibility when minimizing * Update .changes/frameless-minimize-windows.md --------- Co-authored-by: ahodesuka <ahodesuka@users.noreply.github.com>
amrbashir
pushed a commit
that referenced
this pull request
Apr 18, 2023
…909) * fix(windows): Do not toggle webview visibility when minimizing * Update .changes/frameless-minimize-windows.md --------- Co-authored-by: ahodesuka <ahodesuka@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
I am by no means an experienced Rust programmer so if there's a better way of getting the
Rc<Window>into theSetWindowSubclasscallback let me know.Here is the issue that this PR resolves, it is very noticeable here because I'm displaying a large image in the webview.
before-change.mp4
And with these changes it looks like this:
after-change.mp4