-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): restore asset loading functionality to android (fix: #846) #854
fix(android): restore asset loading functionality to android (fix: #846) #854
Conversation
Implements WebViewAssetLoader to load assets from the asset folder in Android when `with_asset_loader` is called in the builder. The function also sets the desired protocol for use in `with_url`, although the url must always be `<protocol>://assets/<path>`. Refs: tauri-apps#846
Hey I didn't have time to review this week, but it's on my todo list. I'll find some time to review it next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll fix our limitation of android_fn
and then merge it.
Awesome! Let me know how empty extra args will be handled and I can fix that part! |
fixed in tauri-apps/tao#688 and will release a new tao version once it is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR!
Implements WebViewAssetLoader to load assets from the asset folder in Android when
with_asset_loader
is called in the builder. The function also sets the desired protocol for use inwith_url
, although the url must always be<protocol>://assets/<path>
.Refs: #846
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
I am willing to provide an update to the
wry
template intauri-mobile
showcasing the correct form of asset loading on Android.