perf: reduce extra allocation at WebViewBuilderExtWindows::with_additional_browser_args
argument
#783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
WebViewBuilderExtWindows::with_additional_browser_args
argument #783Checklist
fix: remove a typo, closes #___, #___
)Other information
Currently
WebViewBuilderExtWindows::with_additional_browser_args
argument is typed withAsRef<str>
. However the method converts the string slice into string buffer with heap allocation. This causes redundant allocation whenString
value is passed.This PR fixes the point.
Strictly speaking, changing from
AsRef<str>
toInto<String>
is a breaking change, but it is very small because major string types like&str
,String
, andCow<'a, str>
can still be passed to the argument.