Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add feature flag to enable private picture-in-picture flag on macos #645

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix: add feature flag to enable private picture-in-picture flag on macos #645

merged 3 commits into from
Aug 5, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jul 30, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

issue is #644

@keiya01 keiya01 requested a review from a team as a code owner July 30, 2022 10:41
wusyong
wusyong reviewed Aug 1, 2022
View reviewed changes
@keiya01 keiya01 mentioned this pull request Aug 1, 2022
Open
2 tasks
@keiya01 keiya01 merged commit 3cfd8c9 into dev Aug 5, 2022
@keiya01 keiya01 deleted the fix/enable-picture-in-picture branch August 5, 2022 00:27
@github-actions github-actions bot mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiya01 @wusyong