Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): multiple custom protocols, closes #323 #324

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner July 1, 2021 16:35
@lucasfernog lucasfernog requested a review from a team July 1, 2021 16:35
@lucasfernog
Copy link
Member Author

Also fixes tauri-apps/tauri#2124

@lucasfernog
Copy link
Member Author

The issue is that all handlers were called on a specific protocol navigation, so one of them returned 404 and caused issues depending on the call order.

@wusyong wusyong merged commit 923d346 into dev Jul 2, 2021
@wusyong wusyong deleted the fix/windows-protocols branch July 2, 2021 07:42
@github-actions github-actions bot mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants