Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebViewAttributes #286

Merged
merged 7 commits into from
Jun 4, 2021
Merged

Add WebViewAttributes #286

merged 7 commits into from
Jun 4, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 4, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong requested a review from a team as a code owner June 4, 2021 06:59
@wusyong wusyong requested a review from a team June 4, 2021 06:59
lemarier
lemarier reviewed Jun 4, 2021
View reviewed changes
src/webview/webview2/mod.rs
mod winrt;
#[cfg(feature = "winrt")]
pub use winrt::*;
// #[cfg(feature = "winrt")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wanted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. But since it's broken already, maybe we should keep the comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alls good for me

@wusyong wusyong merged commit 81f3218 into dev Jun 4, 2021
@wusyong wusyong deleted the feat/attr branch June 4, 2021 09:49
@github-actions github-actions bot mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemarier lemarier lemarier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wusyong @lemarier