Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-protocol): SVG mime type - close #168 #169

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

lemarier
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fix SVG mime type. Tested on macOS. Need more tests on Windows and linux.

@lemarier lemarier requested a review from a team as a code owner April 19, 2021 18:04
@lemarier lemarier requested a review from a team April 19, 2021 18:04
@nothingismagick
Copy link
Member

OMG this is so my bad. I actually participated in some W3C discussions about this and used my "rather have it this way" glasses than the way it really is.

Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows and linux and it's working

@wusyong wusyong merged commit 890cfe5 into dev Apr 20, 2021
@wusyong wusyong deleted the fix/custom-protocol-svg branch April 20, 2021 00:26
@github-actions github-actions bot mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants