Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(windows): backport #994 to allow http scheme for custom protocol #1005

Merged
merged 2 commits into from
Aug 15, 2023
Merged

feat(windows): backport #994 to allow http scheme for custom protocol #1005

merged 2 commits into from
Aug 15, 2023

Conversation

FabianLars
Copy link
Member

Is this the right branch?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

@FabianLars FabianLars requested a review from a team as a code owner August 15, 2023 09:15
amrbashir
amrbashir reviewed Aug 15, 2023
View reviewed changes
@amrbashir amrbashir merged commit 634b021 into v0.24.1 Aug 15, 2023
@amrbashir amrbashir deleted the backport/http-scheme branch August 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianLars @amrbashir