-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Allow for custom URLs for NSIS. WiX, Webview source #12582
Comments
Hello, thank you first of all for your swift reply! Yes, this worked for me, it allowed me to change the URL appropriately, however, I'm getting a TLS issue:
The certificate for I've seen #7338 and #3770 however from what I've gathered for the Tauri V2 release I must put it in the local app data repository, which doesn't appear to be viable given the aforementioned Jenkins configuration. So succinctly, my question is, is there a --insecure flag or something similar I can pass to disable TLS verification? |
Not yet but i think it we can add it for use cases like these. Since you added the cert to the system, it may be enough to enable system certs in ureq. Can you try this maybe?
and if that doesn't work
(uses a better rust crate for the system deps) |
Hello, Thank you again for your reply, I'm currently using @tauri-apps/cli via pnpm, my section in package.json is as follows: "scripts": {
"start": "npm run app-dev",
"app-build": "tauri build",
"app-dev": "tauri dev --no-watch --config ./src-tauri/tauri-dev.conf.json",
"build": "npm run --workspaces --if-present build",
"bootstrap": "run-p bootstrap:* && npm run --workspaces --if-present bootstrap",
"bootstrap:vendor-node": "node scripts/vendor-node.cjs",
"bootstrap:vendor-plugins": "node scripts/vendor-plugins.cjs",
"bootstrap:vendor-protoc": "node scripts/vendor-protoc.cjs",
"lint": "npm run --workspaces --if-present lint",
"replace-version": "node scripts/replace-version.cjs",
"tauri": "tauri",
"tauri-before-build": "npm run bootstrap && npm run --workspaces --if-present build",
"tauri-before-dev": "npm run --workspaces --if-present dev"
}, My current build step is just calling npm app-build, I'm using the TS wrapper, are the flags passable to the TS wrapper too? I cannot really do a cargo install as crates.io is blocked and cargo install doesn't respect the local config.toml (as per rust-lang/cargo#11660) Could you recommend a work-around? Circling back, is there a flag to specify trusted certificates directories, etc? |
Not really. It's a build time thing so we have to rebuild the cli here. While technically possible with the js cli as well, it's not a good fit for CI imo. ref https://v1.tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri-changes (not ported to v2 docs yet - the instructions are wrong for the cli)
This is basically what i'm trying to make you try here. The http client in the cli currently can only use built-in certificates so for any user defined ones we need changes in the cli to try it. Also, system wide installed certs would be much easier to enable than a custom folder so i'd like to start with that and wait to see if the custom folder is really required. |
Helllo, So the first solution appears to work, but simultaneously does not. It doesn't show any progress downloading the actual file, per say, nor does it show the URL again, it simply complains it cannot find nsis
The directory specified does exist and does have makensis.exe in it The other directory does exist I have attempted to vendor a version of makensis and adding to PATH, to no avail (obiviously, as this is now NSIS is called) The situation here is mainly due to how the production machines are configured, they don't allow anything to be run from anything but Is there a variable I can specify the PATH of the NSIS installation to? Or is there a way to just get Tauri to generate the .nsh file and stop there, so I can then run NSIS myself? |
ah yes, ofcourse... 😅
If i see it right and your target dir is in that path too you can use this config https://v2.tauri.app/reference/config/#uselocaltoolsdir |
This feature doesn't appear to be working as intended, it's still going to systemprofile for some weird reason? My target directory is within that "safe" one correct. |
That config will change where the NSIS tools will be downloaded to, so it will only be applied when building your app, not the cli. |
That would be my intention yes, did I put it in the wrong place maybe? 😅 I put in tauri.conf.json > bundle should it be under windows? |
No you did at it correctly probably but in your message the error happens before the |
Oh I see, this is weird because cargo install worked perfectly before this config change 😅 I'll look in to the matter see if I didn't change anything else, but I don't think so |
All resolved, thank you for your help @FabianLars. |
Describe the problem
I'm currently behind a corporate firewall that inhibits downloading from Github as such, all calls to github.com for downloading files are impeded.
As such, I'm unable to correctly finish compilation of a Tauri app as I cannot download the NSIS binaries.
Describe the solution you'd like
Allow for alternative URLs to be specified in the configuration files, so that I can specify an internal URL for an artifactory repository that would contain these files.
Alternatives considered
Usage of a custom proxy to proxy to the archive storage as I'm aware of #7985
However, this is too cumbersome for a resilient deployment pipeline and adds another moving part.
Additional context
No response
The text was updated successfully, but these errors were encountered: