Skip to content

Commit e746c91

Browse files
authored
docs: add note comment (#352)
* docs: add note comment * add fixme comment * docs: add note comment
1 parent 146b2e9 commit e746c91

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

src/lilly.v

+15
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,16 @@ fn (mut lilly Lilly) open_todo_comments_picker() {
225225
lilly.todo_comments_picker_modal = todo_comments_picker
226226
}
227227

228+
// NOTE(tauraamui) [06/04/2025]: actually treesitter support might be unnecessary...
229+
// for features which rely on language specific characteristics
230+
// such as "is this string within a comment or not" should really be
231+
// informed by something more sophisticated per language, so really
232+
// we just need to add LSP support, since they normally use TS or whatever
233+
// they want per language
234+
// for basic stuff like syntax highlighting we can for now get away with just
235+
// using a couple of handwritten parsers, since the new buffer arch requires
236+
// an iterator traversing the full doc contents anyways, this is good enough now
237+
228238
// FIX(tauraamui) [02/03/2025]: should ensure that matches are within a comment block, ideally with treesitter
229239
// but we don't have treesitter support yet, so unsure what to do for now but currently
230240
// ironically due to all of the unit tests for this functionality we're getting a lot of
@@ -351,6 +361,9 @@ pub fn (mut lilly Lilly) on_key_down(e draw.Event) {
351361
lilly.view.on_key_down(e, mut lilly)
352362
}
353363

364+
// NOTE(tauraamui) [06/04/2025]: just tried reading the below comment again, lol wtf am I on about, I understand the premise
365+
// but holy shit what a word salad
366+
354367
// TODO(tauraamui) [21/02/2025]: since these methods receive a concrete ref to the modal directly, rather than this logic
355368
// being directly within the optional type unwrap scope where we're really modifying the result
356369
// of the unwrap rather than the value/field on the struct that the optional was derived from, it might
@@ -400,6 +413,8 @@ pub fn (mut lilly Lilly) todo_comments_picker_on_key_down(mut todo_comments_pick
400413
}
401414
}
402415

416+
// FIX(tauraamui) [06/04/2025]: dirty buffer tracking was broken at some point (sorry kelly!) when doing the partial migration
417+
// to using the gap buffer instead of the existing buffer implementation
403418
pub fn (mut lilly Lilly) quit() ! {
404419
mut dirty_count := 0
405420
for _, buff in lilly.file_buffers {

0 commit comments

Comments
 (0)